Re: [PATCHv3 1/2] rebase: decouple --exec from --interactive

2016-03-19 Thread Junio C Hamano
Junio C Hamano writes: >> +EDITOR="echo >invoked_editor" git rebase --exec "echo a line >> >>exec_output" HEAD~2 2>actual && > > Hmph. If you add "-i" to the command line, do you see the > 'invoked_editor' file created? > > I ask this because I thought we override GIT_EDITOR, which

Re: [PATCHv3 1/2] rebase: decouple --exec from --interactive

2016-03-19 Thread Stefan Beller
On Fri, Mar 18, 2016 at 2:33 PM, Junio C Hamano wrote: >> * Diff to v2 in t3404: >> test_expect_success 'rebase --exec works without -i ' ' >> git reset --hard execute && >> rm -rf exec_output && >> - git rebase --exec "echo a line >>exec_output

Re: [PATCHv3 1/2] rebase: decouple --exec from --interactive

2016-03-19 Thread Junio C Hamano
Stefan Beller writes: > In the later steps of preparing a patch series I do not want to > edit or reorder the patches any more, but just make sure the > test suite passes after each patch and also to fix breakage > right there if some of the steps fail. I could run > > EDITOR=true git rebase

[PATCHv3 1/2] rebase: decouple --exec from --interactive

2016-03-18 Thread Stefan Beller
In the later steps of preparing a patch series I do not want to edit or reorder the patches any more, but just make sure the test suite passes after each patch and also to fix breakage right there if some of the steps fail. I could run EDITOR=true git rebase -i -x "make test" but it would b