On Fri, May 19, 2017 at 11:40 AM, Stefan Beller wrote:
>>> +static unsigned get_line_hash(struct buffered_patch_line *line, unsigned
>>> ignore_ws)
>>> +{
>>> + static struct strbuf sb = STRBUF_INIT;
>>> +
>>> + if (ignore_ws) {
>>> + strbuf_reset();
>>> +
On Fri, May 19, 2017 at 11:23 AM, Jonathan Tan wrote:
> On Thu, 18 May 2017 12:37:46 -0700
> Stefan Beller wrote:
>
> [snip]
>
>> Instead this provides a dynamic programming greedy algorithm that
>
> Not sure if this is called "dynamic programming".
On Thu, 18 May 2017 12:37:46 -0700
Stefan Beller wrote:
[snip]
> Instead this provides a dynamic programming greedy algorithm that
Not sure if this is called "dynamic programming".
> finds the largest moved hunk and then switches color to the
> alternative color for the
When there is a lot of code moved around such as in 11979b9 (2005-11-18,
"http.c: reorder to avoid compilation failure.") for example, the review
process is quite hard, as it is not mentally challenging. It is a rather
tedious process, that gets boring quickly. However you still need to read
4 matches
Mail list logo