Re: [PATCHv5] Add contrib/credentials/netrc with GPG support

2013-02-05 Thread Ted Zlatanov
On Tue, 05 Feb 2013 14:24:01 -0800 Junio C Hamano wrote: JCH> Ted Zlatanov writes: >> +$f =~ s/([;<>\*\|`&\$!#\(\)\[\]\{\}:'"])/\\$1/g; JCH> Yuck. If you really have to quote, it is often far simpler to take JCH> advantage of the fact that quoting rule for shell is much simpler JC

Re: [PATCHv5] Add contrib/credentials/netrc with GPG support

2013-02-05 Thread Junio C Hamano
Junio C Hamano writes: > Otherwise, looks almost ready to me. For now, I've queued this as a minimum fix-up on top of your patch and pushed the result out. It is an equivalent of the previous review comments in a patch form. Please review and incorporate in your reroll as appropriate. I haven

Re: [PATCHv5] Add contrib/credentials/netrc with GPG support

2013-02-05 Thread Junio C Hamano
Ted Zlatanov writes: > + unless (scalar @entries) { > + if ($!) { > + log_verbose("Unable to open $file: $!"); > + } > + else { } else { > + log_verbose("No netrc entries found in $file"); > + }

[PATCHv5] Add contrib/credentials/netrc with GPG support

2013-02-05 Thread Ted Zlatanov
Add Git credential helper that can parse netrc/authinfo files. This credential helper support multiple files, returning the first one that matches. It checks file permissions and owner. For *.gpg files, it will run GPG to decrypt the file. Signed-off-by: Ted Zlatanov --- Changes since PATCHv4: