Re: [PATCHv5] pathspec: give better message for submodule related pathspec error

2017-01-04 Thread Stefan Beller
> I haven't taken a through look at this patch but I think you may want to > base it off of 'origin/bw/pathspec-cleanup' series as the changes made in this > patch now conflict with that series. eh right, I forgot to mention this in the notes, it requires sb/submodule-embed-gitdir as well, so I'll

Re: [PATCHv5] pathspec: give better message for submodule related pathspec error

2017-01-04 Thread Brandon Williams
On 01/04, Stefan Beller wrote: > Every once in a while someone complains to the mailing list to have > run into this weird assertion[1]. The usual response from the mailing > list is link to old discussions[2], and acknowledging the problem > stating it is known. > > This patch accomplishes two th

[PATCHv5] pathspec: give better message for submodule related pathspec error

2017-01-04 Thread Stefan Beller
Every once in a while someone complains to the mailing list to have run into this weird assertion[1]. The usual response from the mailing list is link to old discussions[2], and acknowledging the problem stating it is known. This patch accomplishes two things: 1. Switch assert() to die("BUG") t