Re: [PATCHv5 04/17] diff: introduce more flexible emit function

2017-06-13 Thread Jonathan Tan
On Tue, 13 Jun 2017 16:41:57 -0700 Stefan Beller wrote: > On Tue, Jun 13, 2017 at 2:54 PM, Jonathan Tan > wrote: > > - could this be called emit() instead? > > Despite having good IDEs available some (including me) > very much like working with

Re: [PATCHv5 04/17] diff: introduce more flexible emit function

2017-06-13 Thread Stefan Beller
On Tue, Jun 13, 2017 at 2:54 PM, Jonathan Tan wrote: > On Wed, 24 May 2017 14:40:23 -0700 > Stefan Beller wrote: > >> Currently, diff output is written either through the emit_line_0 >> function or through the FILE * in struct diff_options directly.

Re: [PATCHv5 04/17] diff: introduce more flexible emit function

2017-06-13 Thread Jonathan Tan
On Wed, 24 May 2017 14:40:23 -0700 Stefan Beller wrote: > Currently, diff output is written either through the emit_line_0 > function or through the FILE * in struct diff_options directly. To > make it easier to teach diff to buffer its output (which will be done > in a

[PATCHv5 04/17] diff: introduce more flexible emit function

2017-05-24 Thread Stefan Beller
Currently, diff output is written either through the emit_line_0 function or through the FILE * in struct diff_options directly. To make it easier to teach diff to buffer its output (which will be done in a subsequent commit), introduce a more flexible emit_line() function. In this commit, direct