Re: [PATCHv5 3/4] submodule: rename and add flags to ok_to_remove_submodule

2016-12-27 Thread Stefan Beller
On Mon, Dec 26, 2016 at 4:53 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> As only 0 is understood as false, rename the function to invert the >> meaning, i.e. the return code of 0 signals the removal of the submodule >> is fine, and other values

Re: [PATCHv5 3/4] submodule: rename and add flags to ok_to_remove_submodule

2016-12-26 Thread Junio C Hamano
Stefan Beller writes: > As only 0 is understood as false, rename the function to invert the > meaning, i.e. the return code of 0 signals the removal of the submodule > is fine, and other values can be used to return a more precise answer > what went wrong. Makes sense to

[PATCHv5 3/4] submodule: rename and add flags to ok_to_remove_submodule

2016-12-20 Thread Stefan Beller
In different contexts the question "Is it ok to delete a submodule?" may be answered differently. In 293ab15eea (submodule: teach rm to remove submodules unless they contain a git directory, 2012-09-26) a case was made that we can safely ignore ignored untracked files for removal as we