Re: [PATCHv5 8/8] clone: recursive and reference option triggers submodule alternates

2016-08-31 Thread Jacob Keller
On Tue, Aug 30, 2016 at 10:04 PM, Stefan Beller wrote: > On Wed, Aug 24, 2016 at 4:37 PM, Jacob Keller wrote: > >> Yes that seems reasonable. >> >> Thanks, >> Jake > > I reviewed all your comments and you seem to be ok with including this > series as

Re: [PATCHv5 8/8] clone: recursive and reference option triggers submodule alternates

2016-08-30 Thread Stefan Beller
On Wed, Aug 24, 2016 at 4:37 PM, Jacob Keller wrote: > Yes that seems reasonable. > > Thanks, > Jake I reviewed all your comments and you seem to be ok with including this series as it is queued currently? Thanks, Stefan

Re: [PATCHv5 8/8] clone: recursive and reference option triggers submodule alternates

2016-08-24 Thread Jacob Keller
On Wed, Aug 24, 2016 at 3:52 PM, Stefan Beller wrote: > On Tue, Aug 23, 2016 at 11:29 PM, Jacob Keller wrote: >> On Tue, Aug 23, 2016 at 4:03 PM, Stefan Beller wrote: > + > + if (option_recursive) { > +

Re: [PATCHv5 8/8] clone: recursive and reference option triggers submodule alternates

2016-08-24 Thread Stefan Beller
On Tue, Aug 23, 2016 at 11:29 PM, Jacob Keller wrote: > On Tue, Aug 23, 2016 at 4:03 PM, Stefan Beller wrote: + + if (option_recursive) { + if (option_required_reference.nr && +

Re: [PATCHv5 8/8] clone: recursive and reference option triggers submodule alternates

2016-08-24 Thread Jacob Keller
On Tue, Aug 23, 2016 at 4:03 PM, Stefan Beller wrote: >>> + >>> + if (option_recursive) { >>> + if (option_required_reference.nr && >>> + option_optional_reference.nr) >>> + die(_("clone --recursive is not compatible

Re: [PATCHv5 8/8] clone: recursive and reference option triggers submodule alternates

2016-08-23 Thread Stefan Beller
>> + >> + if (option_recursive) { >> + if (option_required_reference.nr && >> + option_optional_reference.nr) >> + die(_("clone --recursive is not compatible with " >> + "both --reference and

Re: [PATCHv5 8/8] clone: recursive and reference option triggers submodule alternates

2016-08-23 Thread Jacob Keller
On Mon, Aug 15, 2016 at 2:53 PM, Stefan Beller wrote: > When `--recursive` and `--reference` is given, it is reasonable to > expect that the submodules are created with references to the submodules > of the given alternate for the superproject. > > An initial attempt to do

[PATCHv5 8/8] clone: recursive and reference option triggers submodule alternates

2016-08-15 Thread Stefan Beller
When `--recursive` and `--reference` is given, it is reasonable to expect that the submodules are created with references to the submodules of the given alternate for the superproject. An initial attempt to do this was presented to the mailing list, which used flags that are passed around