Re: [PATCHv6 2/2] pathspec: give better message for submodule related pathspec error

2017-01-09 Thread Stefan Beller
On Sun, Jan 8, 2017 at 6:39 PM, Junio C Hamano wrote: > For future reference, do not bury a useful fix behind unproven new > things. The main purpose of this two-patch series is this change, > and it does not have to wait for the change to allow test_commit to > notice "-C" you have in another se

Re: [PATCHv6 2/2] pathspec: give better message for submodule related pathspec error

2017-01-08 Thread Junio C Hamano
Stefan Beller writes: > Every once in a while someone complains to the mailing list to have > run into this weird assertion[1]. The usual response from the mailing > list is link to old discussions[2], and acknowledging the problem > stating it is known. > > This patch accomplishes two things: >

[PATCHv6 2/2] pathspec: give better message for submodule related pathspec error

2017-01-05 Thread Stefan Beller
Every once in a while someone complains to the mailing list to have run into this weird assertion[1]. The usual response from the mailing list is link to old discussions[2], and acknowledging the problem stating it is known. This patch accomplishes two things: 1. Switch assert() to die("BUG") t