Re: [PATCHv6 2/7] submodule helper: support super prefix

2016-12-08 Thread Stefan Beller
> > unsigned int is probably safer for variables that are used as bit-flags. done > If it's meant for users to see, please _() the string. done >> + { "submodule--helper", cmd_submodule__helper, RUN_SETUP | >> SUPPORT_SUPER_PREFIX}, > > The same macro defined twice in two separate .c fil

Re: [PATCHv6 2/7] submodule helper: support super prefix

2016-12-08 Thread Duy Nguyen
On Thu, Dec 8, 2016 at 8:46 AM, Stefan Beller wrote: > Just like main commands in Git, the submodule helper needs > access to the superproject prefix. Enable this in the git.c > but have its own fuse in the helper code by having a flag to > turn on the super prefix. > > Signed-off-by: Stefan Belle

[PATCHv6 2/7] submodule helper: support super prefix

2016-12-07 Thread Stefan Beller
Just like main commands in Git, the submodule helper needs access to the superproject prefix. Enable this in the git.c but have its own fuse in the helper code by having a flag to turn on the super prefix. Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano --- builtin/submodule--helper.