Re: [PATCHv7 0/6] submodule absorbgitdirs

2016-12-12 Thread Stefan Beller
On Mon, Dec 12, 2016 at 12:35 PM, Brandon Williams wrote: > On 12/12, Stefan Beller wrote: >> v8: >> * Change the worktree implementation: do not have an internal >> submodule_get_worktrees, and count the number of worktrees, instead >> directly look if there is a worktrees

Re: [PATCHv7 0/6] submodule absorbgitdirs

2016-12-12 Thread Brandon Williams
On 12/12, Stefan Beller wrote: > v8: > * Change the worktree implementation: do not have an internal > submodule_get_worktrees, and count the number of worktrees, instead > directly look if there is a worktrees dir and check if there are any files > in there. > * reworded one test title

[PATCHv7 0/6] submodule absorbgitdirs

2016-12-12 Thread Stefan Beller
v8: * Change the worktree implementation: do not have an internal submodule_get_worktrees, and count the number of worktrees, instead directly look if there is a worktrees dir and check if there are any files in there. * reworded one test title slightly. * interdiff to v7 (that is queued as

[PATCHv7 0/6] submodule absorbgitdirs

2016-12-08 Thread Stefan Beller
v7: * do not expose submodule_get_worktrees. The values may be wrong internally, but for our purpose we do not care about the actual values, only the count. Document the wrong values! * more strings are _(marked up) * renamed variables in connect_work_tree_and_git_dir * unsigned instead of int