Re: [PATCHv8 5/9] receive-pack.c: move transaction handling in a central place

2014-12-30 Thread Eric Sunshine
On Tue, Dec 30, 2014 at 1:45 PM, Stefan Beller wrote: > On Tue, Dec 30, 2014 at 12:36 AM, Eric Sunshine > wrote: >> On Mon, Dec 29, 2014 at 9:36 PM, Stefan Beller wrote: >>> No functional changes intended. >> >> Secondary information can be demoted to the end of the commit message. > > I think

Re: [PATCHv8 5/9] receive-pack.c: move transaction handling in a central place

2014-12-30 Thread Stefan Beller
On Tue, Dec 30, 2014 at 12:36 AM, Eric Sunshine wrote: > On Mon, Dec 29, 2014 at 9:36 PM, Stefan Beller wrote: >> Subject: receive-pack.c: move transaction handling in a central place > > This is very generic, and doesn't really explain what this patch is > about. (See below.) > >> No functional

Re: [PATCHv8 5/9] receive-pack.c: move transaction handling in a central place

2014-12-30 Thread Eric Sunshine
On Mon, Dec 29, 2014 at 9:36 PM, Stefan Beller wrote: > Subject: receive-pack.c: move transaction handling in a central place This is very generic, and doesn't really explain what this patch is about. (See below.) > No functional changes intended. Secondary information can be demoted to the end

[PATCHv8 5/9] receive-pack.c: move transaction handling in a central place

2014-12-29 Thread Stefan Beller
No functional changes intended. This moves all code related to transactions into the execute_commands_loop function which was factored out of execute_commands. This includes beginning and committing the transaction as well as dealing with the errors which may occur during the begin and commit phase