Re: [Patch size_t V3 17/19] Convert ref-filter to size_t

2017-08-17 Thread Junio C Hamano
Junio C Hamano writes: > I did not see anything fishy in the remaining parts I did not > comment on. > > Thanks. What I meant was "remainder of this patch 17/19". I am not claiming that I read all other patches; I haven't, not yet anyway.

Re: [Patch size_t V3 17/19] Convert ref-filter to size_t

2017-08-17 Thread Junio C Hamano
Martin Koegler writes: > -static char *copy_subject(const char *buf, unsigned long len) > +static char *copy_subject(const char *buf, size_t len) > { > char *r = xmemdupz(buf, len); > int i; This has the same "we are still iterating with 'int i' over an array that can be 'size_t len

[Patch size_t V3 17/19] Convert ref-filter to size_t

2017-08-16 Thread Martin Koegler
From: Martin Koegler Signed-off-by: Martin Koegler --- ref-filter.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/ref-filter.c b/ref-filter.c index 5c903a5..30f249c 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -724,7 +724,7 @@ static