Re: [RFC/PATCH] align D/F handling of diff --no-index with that of normal Git

2015-03-22 Thread Ramsay Jones
On 22/03/15 05:11, Junio C Hamano wrote: When a commit changes a path P that used to be a file to a directory and create a new path P/X in it, git show would say that file P was removed and file P/X was created for such a commit. However, if we compare two directories, D1 and D2, where D1

Re: [RFC/PATCH] align D/F handling of diff --no-index with that of normal Git

2015-03-22 Thread Junio C Hamano
On Sun, Mar 22, 2015 at 5:37 AM, Ramsay Jones ram...@ramsay1.demon.co.uk wrote: On 22/03/15 05:11, Junio C Hamano wrote: + if (S_ISDIR(mode1)) { + /* 2 is file that is created */ + d1 = noindex_filespec(NULL, 0); + d2 =

Re: [RFC/PATCH] align D/F handling of diff --no-index with that of normal Git

2015-03-22 Thread Eric Sunshine
On Sun, Mar 22, 2015 at 1:11 AM, Junio C Hamano gits...@pobox.com wrote: When a commit changes a path P that used to be a file to a directory and create a new path P/X in it, git show would say that file P s/create/creates/ More below... was removed and file P/X was created for such a

[RFC/PATCH] align D/F handling of diff --no-index with that of normal Git

2015-03-21 Thread Junio C Hamano
When a commit changes a path P that used to be a file to a directory and create a new path P/X in it, git show would say that file P was removed and file P/X was created for such a commit. However, if we compare two directories, D1 and D2, where D1 has a file D1/P in it and D2 has a directory