Re: [RFC/PATCH] headers: normalize the spelling of some header guards

2018-10-14 Thread Junio C Hamano
Jeff King writes: > I'm in favor of normalizing even the ones that aren't illegal, though > I'm OK either way on the vcs-svn bits if they're going away anyway. I'm in favour of normalizing even the ones that aren't illegal, too.

Re: [RFC/PATCH] headers: normalize the spelling of some header guards

2018-10-14 Thread Ramsay Jones
On 15/10/18 00:59, Jeff King wrote: > On Sun, Oct 14, 2018 at 09:13:09PM +0100, Ramsay Jones wrote: > >> This patch is marked RFC because I am not aware of any policy with >> regard to header guard spelling. Having said that, apart from the >> fetch-negotiator.h header, all of these headers are

Re: [RFC/PATCH] headers: normalize the spelling of some header guards

2018-10-14 Thread Jeff King
On Sun, Oct 14, 2018 at 09:13:09PM +0100, Ramsay Jones wrote: > This patch is marked RFC because I am not aware of any policy with > regard to header guard spelling. Having said that, apart from the > fetch-negotiator.h header, all of these headers are using a reserved > identifier (see C99 Standa

Re: [RFC/PATCH] headers: normalize the spelling of some header guards

2018-10-14 Thread brian m. carlson
On Sun, Oct 14, 2018 at 09:13:09PM +0100, Ramsay Jones wrote: > > Signed-off-by: Ramsay Jones > --- > > Hi Junio, > > This patch is marked RFC because I am not aware of any policy with > regard to header guard spelling. Having said that, apart from the > fetch-negotiator.h header, all of these

[RFC/PATCH] headers: normalize the spelling of some header guards

2018-10-14 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Junio, This patch is marked RFC because I am not aware of any policy with regard to header guard spelling. Having said that, apart from the fetch-negotiator.h header, all of these headers are using a reserved identifier (see C99 Standard 7.1.3). These header