Re: [RFC/PATCH] notes: Allow adding empty notes with -C

2014-09-21 Thread Johan Herland
On Sun, Sep 21, 2014 at 10:53 AM, Torsten Bögershausen wrote: > On 2014-09-21 05.00, Johan Herland wrote: [...] >> +cat > expect << EOF > Git style for shell scripts: Plase put no space between < or > or >> and the > file name: > cat >expect <> + git log -1 > actual && > git log -1 >actual

Re: [RFC/PATCH] notes: Allow adding empty notes with -C

2014-09-21 Thread Torsten Bögershausen
On 2014-09-21 05.00, Johan Herland wrote: [] > diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh > index cfd67ff..a6c399b 100755 > --- a/t/t3301-notes.sh > +++ b/t/t3301-notes.sh > @@ -1239,4 +1239,23 @@ test_expect_success 'git notes get-ref (--ref)' ' > test "$(GIT_NOTES_REF=refs/notes/bar g

[RFC/PATCH] notes: Allow adding empty notes with -C

2014-09-20 Thread Johan Herland
Although the "git notes" man page advertises that we support binary-safe notes addition with the -C option, we currently do not support adding the empty note (i.e. using the empty blob to annotate an object). Instead, an empty note is always treated as an intent to remove the note altogether. Intr