Re: [RFC/PATCH 2/4] cat-file: do not die on --textconv without textconv filters

2013-02-06 Thread Jeff King
On Wed, Feb 06, 2013 at 02:23:36PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > Which made me wonder: what happens with: > > > > git cat-file --textconv HEAD > > > > It looks like we die just before textconv-ing, because we have no > > obj_context.path. But that is also unlike all of

Re: [RFC/PATCH 2/4] cat-file: do not die on --textconv without textconv filters

2013-02-06 Thread Junio C Hamano
Jeff King writes: > Which made me wonder: what happens with: > > git cat-file --textconv HEAD > > It looks like we die just before textconv-ing, because we have no > obj_context.path. But that is also unlike all of the other --textconv > switches, which mean "turn on textconv if you are showing

Re: [RFC/PATCH 2/4] cat-file: do not die on --textconv without textconv filters

2013-02-06 Thread Jeff King
On Wed, Feb 06, 2013 at 04:08:51PM +0100, Michael J Gruber wrote: > When a command is supposed to use textconv filters (by default or with > "--textconv") and none are configured then the blob is output without > conversion; the only exception to this rule is "cat-file --textconv". > > Make it be

Re: [RFC/PATCH 2/4] cat-file: do not die on --textconv without textconv filters

2013-02-06 Thread Junio C Hamano
Michael J Gruber writes: > When a command is supposed to use textconv filters (by default or with > "--textconv") and none are configured then the blob is output without > conversion; the only exception to this rule is "cat-file --textconv". I am of two minds. Because cat-file is mostly a low-l

[RFC/PATCH 2/4] cat-file: do not die on --textconv without textconv filters

2013-02-06 Thread Michael J Gruber
When a command is supposed to use textconv filters (by default or with "--textconv") and none are configured then the blob is output without conversion; the only exception to this rule is "cat-file --textconv". Make it behave like the rest of textconv aware commands. Signed-off-by: Michael J Grub