Re: [RFC/PATCH 3/5] connect.c: connect to a remote service with some flags

2015-02-28 Thread Junio C Hamano
Stefan Beller writes: > If this is over git protocol, the flags is appended as the next > parameter after host=. If it's ssh, a new argument is appended to the > command line. > > None of the callers use this now though. Replace "some flags" with something more meaningful, so that the reader can

Re: [RFC/PATCH 3/5] connect.c: connect to a remote service with some flags

2015-02-28 Thread Torsten Bögershausen
On 2015-02-28 02.01, Stefan Beller wrote: > If this is over git protocol, the flags is appended as the next > parameter after host=. If it's ssh, a new argument is appended to the > command line. > > None of the callers use this now though. > > [sb: originally by pclouds, rebased as jk implement

[RFC/PATCH 3/5] connect.c: connect to a remote service with some flags

2015-02-27 Thread Stefan Beller
If this is over git protocol, the flags is appended as the next parameter after host=. If it's ssh, a new argument is appended to the command line. None of the callers use this now though. [sb: originally by pclouds, rebased as jk implemented 1823bea10, (git_connect: use argv_array), so any error