Re: [RFC/PATCH v11 11/13] bisect--helper: `bisect_next_check` shell function in C

2016-08-03 Thread Pranit Bauva
Hey Junio, On Wed, Aug 3, 2016 at 12:47 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> +static int mark_good(const char *refname, const struct object_id *oid, >> + int flag, void *cb_data) >> +{ >> + int *m_good = (int *)cb_data; >> + *m_good = 0; >> + return

Re: [RFC/PATCH v11 11/13] bisect--helper: `bisect_next_check` shell function in C

2016-08-02 Thread Junio C Hamano
Pranit Bauva writes: > +static int mark_good(const char *refname, const struct object_id *oid, > + int flag, void *cb_data) > +{ > + int *m_good = (int *)cb_data; > + *m_good = 0; > + return 0; > +} See below. > +static int bisect_next_check(const struct bisect_term

[RFC/PATCH v11 11/13] bisect--helper: `bisect_next_check` shell function in C

2016-07-31 Thread Pranit Bauva
Reimplement `bisect_next_check` shell function in C and add `bisect-next-check` subcommand to `git bisect--helper` to call it from git-bisect.sh . Using `--bisect-next-check` is a temporary measure to port shell function to C so as to use the existing test suite. As more functions are ported, this