Re: [RFC/PATCH v2] create a skeleton for the command git rebase --status

2015-05-29 Thread Guillaume Pages
After this discussion I eventually agree that it would be better upgrading git status than creating a new command.When people use git status, it means that they need information to continue their work, so if you don't even know that you are in a rebase, you will very likely need information about

Re: [RFC/PATCH v2] create a skeleton for the command git rebase --status

2015-05-29 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: Guillaume Pages guillaume.pa...@ensimag.grenoble-inp.fr writes: ... And during an interactive rebase: rebase in progress; This could even become interactive rebase in progress. Most of the time, you're supposed to remember whether you ran

Re: [RFC/PATCH v2] create a skeleton for the command git rebase --status

2015-05-29 Thread Matthieu Moy
Guillaume Pages guillaume.pa...@ensimag.grenoble-inp.fr writes: rebase in progress; onto d9d448a You are currently rebasing branch 'branche1' on 'd9d448a'. (fix conflicts and then run git rebase --continue) (use git rebase --skip to skip this patch) (use git rebase --abort to check out the

Re: [RFC/PATCH v2] create a skeleton for the command git rebase --status

2015-05-28 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: But I think there are more relevant information to show (e.g. list of already applied commits, remaining list of commits, possibly truncated if the list is overly long, and information that rebase gave you when stopping like the path to the

Re: [RFC/PATCH v2] create a skeleton for the command git rebase --status

2015-05-28 Thread Junio C Hamano
Matthieu Moy matthieu@grenoble-inp.fr writes: Junio C Hamano gits...@pobox.com writes: If this topic enhances 'git status' with the in-progress rebase information, I'd view it as turning 'git status' from 'a more or less useless command during rebase' to 'a useful command'. For

Re: [RFC/PATCH v2] create a skeleton for the command git rebase --status

2015-05-28 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: If this topic enhances 'git status' with the in-progress rebase information, I'd view it as turning 'git status' from 'a more or less useless command during rebase' to 'a useful command'. For day-to-day operations, what we already have in status

[RFC/PATCH v2] create a skeleton for the command git rebase --status

2015-05-28 Thread Guillaume Pagès
Preparatory commit for a git rebase --status command. This command will indicate the state of the process in the rebase, and the reason why it stopped. Signed-off-by: Guillaume Pagès guillaume.pa...@ensimag.grenoble-inp.fr --- The observations from Matthieu Moy have been taken into account It

Re: [RFC/PATCH v2] create a skeleton for the command git rebase --status

2015-05-28 Thread Matthieu Moy
Guillaume Pages guillaume.pa...@ensimag.grenoble-inp.fr writes: Hi, Paul Tan pyoka...@gmail.com : I haven't kept up with the discussion, but I'm wondering: since you need the functionality in wt-status.c, why not implement it in git status? In fact, git-status already shows if there is

Re: [RFC/PATCH v2] create a skeleton for the command git rebase --status

2015-05-28 Thread Matthieu Moy
Guillaume Pagès guillaume.pa...@ensimag.grenoble-inp.fr writes: It is an almost empty code sent to validate the global architecture of this command. It is written in C because git status is already in C and it seems that it is the current tendency to port shell code to C. Moreover will