Re: [RFC] a tale of Git 2.5, ssh transport and GIT_* environment variables

2015-09-04 Thread Jeff King
On Fri, Sep 04, 2015 at 11:18:01AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > It shouldn't be necessary for $GIT_DIR, but it makes sense for other git > > variables. E.g., with "AcceptEnv GIT_*", "git -c" config is propagated. > > E.g.: > > ... > > Just to make sure I got you correc

Re: [RFC] a tale of Git 2.5, ssh transport and GIT_* environment variables

2015-09-04 Thread Giuseppe Bilotta
On Fri, Sep 4, 2015 at 8:18 PM, Junio C Hamano wrote: > Jeff King writes: > >> It shouldn't be necessary for $GIT_DIR, but it makes sense for other git >> variables. E.g., with "AcceptEnv GIT_*", "git -c" config is propagated. >> E.g.: >> ... > > Just to make sure I got you correctly, you are say

Re: [RFC] a tale of Git 2.5, ssh transport and GIT_* environment variables

2015-09-04 Thread Junio C Hamano
Jeff King writes: > It shouldn't be necessary for $GIT_DIR, but it makes sense for other git > variables. E.g., with "AcceptEnv GIT_*", "git -c" config is propagated. > E.g.: > ... Just to make sure I got you correctly, you are saying that "we propagate, but that is not correct. We should stop d

Re: [RFC] a tale of Git 2.5, ssh transport and GIT_* environment variables

2015-09-04 Thread Jeff King
On Fri, Sep 04, 2015 at 04:02:09PM +0200, Giuseppe Bilotta wrote: > So, I've at least been able to circumscribe the problem to: server git > 1.7.0.4, client git 2.5, GIT_WORK_TREE being sent over the ssh > connection. I'll see if I can find some time to do some proper > bisecting next week. That

Re: [RFC] a tale of Git 2.5, ssh transport and GIT_* environment variables

2015-09-04 Thread Giuseppe Bilotta
Hello, On Fri, Sep 4, 2015 at 2:54 PM, Jeff King wrote: > On Fri, Sep 04, 2015 at 12:52:45PM +0200, Giuseppe Bilotta wrote: > >> Notice two things: the messages refer to the worktree updir of the >> CLIENT machine, and even though it's _completely not obvious_ due to >> the missing 'remote:' line

Re: [RFC] a tale of Git 2.5, ssh transport and GIT_* environment variables

2015-09-04 Thread Jeff King
On Fri, Sep 04, 2015 at 12:52:45PM +0200, Giuseppe Bilotta wrote: > Trying to push any changes with 2.5 resulted in this kind of failure: > > user@clientmachine:~/some/git/workdir $ git push > Counting objects: 6, done. > Delta compression using up to 8 threads. > Compressing objects: 100% (5/5),

[RFC] a tale of Git 2.5, ssh transport and GIT_* environment variables

2015-09-04 Thread Giuseppe Bilotta
Hello all, I'm going to tell a tale of the oddest bug I've ever come across in Git and aks for suggestions on how we can improve the user experience in a sensible way. I've been stymied for days trying to solve the following issue, which I came across every time I tried to push to a specific mac