Re: [RFC 1/2] grep: only add delimiter if there isn't one already

2017-01-24 Thread Philip Oakley
From: "Jakub Narębski" W dniu 23.01.2017 o 14:15, Stefan Hajnoczi pisze: On Fri, Jan 20, 2017 at 10:16:31AM -0800, Junio C Hamano wrote: My only piece of advice to folks who feel that way is to learn Git more and get comfortable. You can do neat things like $ git grep

Re: [RFC 1/2] grep: only add delimiter if there isn't one already

2017-01-24 Thread Jakub Narębski
W dniu 23.01.2017 o 14:15, Stefan Hajnoczi pisze: > On Fri, Jan 20, 2017 at 10:16:31AM -0800, Junio C Hamano wrote: >> My only piece of advice to folks who feel that way is to learn Git >> more and get comfortable. You can do neat things like >> >>$ git grep -e pattern rev -- t ':!t/helper/'

Re: [RFC 1/2] grep: only add delimiter if there isn't one already

2017-01-24 Thread Stefan Hajnoczi
On Fri, Jan 20, 2017 at 10:16:31AM -0800, Junio C Hamano wrote: > Stefan Hajnoczi writes: > > > v2.9.3::Makefile may convey that the user originally provided v2.9.3: > > but is that actually useful information? > > You are either asking a wrong question, or asking a wrong

Re: [RFC 1/2] grep: only add delimiter if there isn't one already

2017-01-20 Thread Junio C Hamano
Stefan Hajnoczi writes: > v2.9.3::Makefile may convey that the user originally provided v2.9.3: > but is that actually useful information? You are either asking a wrong question, or asking a wrong person (i.e. Git) the question. The real question is why the user added a

Re: [RFC 1/2] grep: only add delimiter if there isn't one already

2017-01-20 Thread Stefan Hajnoczi
On Thu, Jan 19, 2017 at 10:39:02AM -0800, Junio C Hamano wrote: > Stefan Hajnoczi writes: > > > git-grep(1) output does not follow git's own syntax: > > > > $ git grep malloc v2.9.3: > > v2.9.3::Makefile: COMPAT_CFLAGS += -Icompat/nedmalloc > > $ git show

Re: [RFC 1/2] grep: only add delimiter if there isn't one already

2017-01-19 Thread Junio C Hamano
Stefan Hajnoczi writes: > git-grep(1) output does not follow git's own syntax: > > $ git grep malloc v2.9.3: > v2.9.3::Makefile: COMPAT_CFLAGS += -Icompat/nedmalloc > $ git show v2.9.3::Makefile > fatal: Path ':Makefile' does not exist in 'v2.9.3' > > This

[RFC 1/2] grep: only add delimiter if there isn't one already

2017-01-19 Thread Stefan Hajnoczi
git-grep(1) output does not follow git's own syntax: $ git grep malloc v2.9.3: v2.9.3::Makefile: COMPAT_CFLAGS += -Icompat/nedmalloc $ git show v2.9.3::Makefile fatal: Path ':Makefile' does not exist in 'v2.9.3' This patch avoids emitting the unnecessary ':' delimiter if the name