Re: [RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling

On 06/12/16 18:26, Jeff King wrote: > On Tue, Dec 06, 2016 at 10:17:55AM -0800, Junio C Hamano wrote: > >> Yup, that is what I meant to say with "that is already possible" and >> we are on the same page. As all three of us seem to be happy with >> just dropping --abbrev and letting describe do

Re: [RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling

On Tue, Dec 06, 2016 at 10:17:55AM -0800, Junio C Hamano wrote: > Yup, that is what I meant to say with "that is already possible" and > we are on the same page. As all three of us seem to be happy with > just dropping --abbrev and letting describe do its default thing (as > configured by

Re: [RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling

Jeff King writes: > On Mon, Dec 05, 2016 at 10:01:19AM -0800, Junio C Hamano wrote: > >> > That said, I think the right patch may be to just drop --abbrev >> > entirely. >> > ... >> > I think at that point it was a noop, as 7 should have been the default. >> > And now we probably

Re: [RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling

On Mon, Dec 05, 2016 at 10:01:19AM -0800, Junio C Hamano wrote: > > That said, I think the right patch may be to just drop --abbrev > > entirely. > > ... > > I think at that point it was a noop, as 7 should have been the default. > > And now we probably ought to drop it, so that we can use the >

Re: [RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling

On 05/12/16 22:24, Junio C Hamano wrote: > Ramsay Jones writes: > >> As I said, the original version of the patch just removed the >> --abbrev=7, but then I started to think about why you might have >> used --abbrev in the first place (first in commit 9b88fcef7 and

Re: [RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling

Ramsay Jones writes: > As I said, the original version of the patch just removed the > --abbrev=7, but then I started to think about why you might have > used --abbrev in the first place (first in commit 9b88fcef7 and > again in commit bf505158d). Making sure to

Re: [RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling

On 05/12/16 18:10, Junio C Hamano wrote: > Ramsay Jones writes: > >> Heh, that was the first version of the patch. However, I got to thinking >> about why --abbrev=7 was there in the first place; the only reason I >> could think of was to defeat local configuration

Re: [RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling

Ramsay Jones writes: > Heh, that was the first version of the patch. However, I got to thinking > about why --abbrev=7 was there in the first place; the only reason I > could think of was to defeat local configuration to get a measure of > reproducibility. > >

Re: [RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling

Jeff King writes: > On Sun, Dec 04, 2016 at 08:45:59PM +, Ramsay Jones wrote: > >> >> Signed-off-by: Ramsay Jones >> --- >> >> Hi Junio, >> >> I recently noticed that: >> >> $ make >pout 2>&1 >> $ ./git version >> git version

Re: [RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling

On 05/12/16 05:32, Jeff King wrote: > On Sun, Dec 04, 2016 at 08:45:59PM +, Ramsay Jones wrote: >> I recently noticed that: >> >> $ make >pout 2>&1 >> $ ./git version >> git version 2.11.0.286.g109e8a9 >> $ git describe >> v2.11.0-286-g109e8a99d >> $ >> >> ... for

Re: [RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling

On Sun, Dec 04, 2016 at 08:45:59PM +, Ramsay Jones wrote: > > Signed-off-by: Ramsay Jones > --- > > Hi Junio, > > I recently noticed that: > > $ make >pout 2>&1 > $ ./git version > git version 2.11.0.286.g109e8a9 > $ git describe >

[RFC PATCH] GIT-VERSION-GEN: set --abbrev=9 to match auto-scaling

Signed-off-by: Ramsay Jones --- Hi Junio, I recently noticed that: $ make >pout 2>&1 $ ./git version git version 2.11.0.286.g109e8a9 $ git describe v2.11.0-286-g109e8a99d $ ... for non-release builds, the commit part of the version string