Re: [RFC PATCH] color: respect the $NO_COLOR convention

2018-03-04 Thread Junio C Hamano
"brian m. carlson" writes: > As a note, turning off color can improve accessibility for some people. > I have a co-worker who has deuteranomaly and virtually all colored text > at the terminal poses readability problems. It would be beneficial if > he could just

Re: [RFC PATCH] color: respect the $NO_COLOR convention

2018-03-04 Thread brian m. carlson
On Thu, Mar 01, 2018 at 11:06:45AM -0800, Junio C Hamano wrote: > Leah Neukirchen writes: > > > You are right in calling this out an emerging new thing, but the > > second list of that page proves that it will be useful to settle on a > > common configuration, and my hope is by

Re: [RFC PATCH] color: respect the $NO_COLOR convention

2018-03-01 Thread Junio C Hamano
Leah Neukirchen writes: > You are right in calling this out an emerging new thing, but the > second list of that page proves that it will be useful to settle on a > common configuration, and my hope is by getting a few popular projects > on board, others will soon follow. It

Re: [RFC PATCH] color: respect the $NO_COLOR convention

2018-03-01 Thread Leah Neukirchen
Junio C Hamano writes: > Leah Neukirchen writes: > >> NO_COLOR (http://no-color.org/) is a comprehensive approach to disable >> colors by default for all tools: > > The list of software that supports that "convention" is, eh, > respectable. Is it really a

Re: [RFC PATCH] color: respect the $NO_COLOR convention

2018-03-01 Thread Junio C Hamano
Leah Neukirchen writes: > NO_COLOR (http://no-color.org/) is a comprehensive approach to disable > colors by default for all tools: The list of software that supports that "convention" is, eh, respectable. Is it really a "convention" yet, or yet another thing the user needs to

[RFC PATCH] color: respect the $NO_COLOR convention

2018-03-01 Thread Leah Neukirchen
When the NO_COLOR environment variable is set to any value, default to disabling color, i.e. resolve 'auto' to false. NO_COLOR (http://no-color.org/) is a comprehensive approach to disable colors by default for all tools: > All command-line software which outputs text with ANSI color added >