Re: [RFC PATCH 01/10] config: make config_from_gitmodules generally useful

> OK, the fact I was overlooking was that the "config_fn_t" argument > passed to config_from_gitmodules is what we are actually worried about, > it's the config callback which could allow generic config in .gitmodules > to sneak in. That is the precise point that I was trying to communicate. :)

Re: [RFC PATCH 01/10] config: make config_from_gitmodules generally useful

On Wed, 20 Jun 2018 12:10:42 -0700 Stefan Beller wrote: > Hi Antonio! > > On Wed, Jun 20, 2018 at 11:06 AM Antonio Ospite wrote: > > I get that the _content_ of .gitmodules is not meant to be generic > > config, but I still see some value in having a single point when its > > _location_ is

Re: [RFC PATCH 01/10] config: make config_from_gitmodules generally useful

Hi Antonio! On Wed, Jun 20, 2018 at 11:06 AM Antonio Ospite wrote: > I get that the _content_ of .gitmodules is not meant to be generic > config, but I still see some value in having a single point when its > _location_ is decided. I agree that a single point for the _location_ as well as the

Re: [RFC PATCH 01/10] config: make config_from_gitmodules generally useful

On Mon, 14 May 2018 11:19:28 -0700 Brandon Williams wrote: Hi Brandon, sorry for the delay, some comments below. > On 05/14, Antonio Ospite wrote: > > The config_from_gitmodules() function is a good candidate for > > a centralized point where to read the gitmodules configuration file. > > > >

Re: [RFC PATCH 01/10] config: make config_from_gitmodules generally useful

On Mon, 14 May 2018 18:05:19 -0700 Stefan Beller wrote: Hi again Stefan, > On Mon, May 14, 2018 at 3:58 AM, Antonio Ospite wrote: > > The config_from_gitmodules() function is a good candidate for > > a centralized point where to read the gitmodules configuration file. > > It is very tempting

Re: [RFC PATCH 01/10] config: make config_from_gitmodules generally useful

On Mon, May 14, 2018 at 3:58 AM, Antonio Ospite wrote: > The config_from_gitmodules() function is a good candidate for > a centralized point where to read the gitmodules configuration file. It is very tempting to use that function. However it was introduced specifically to not do

Re: [RFC PATCH 01/10] config: make config_from_gitmodules generally useful

On 05/14, Antonio Ospite wrote: > The config_from_gitmodules() function is a good candidate for > a centralized point where to read the gitmodules configuration file. > > Add a repo argument to it to make the function more general, and adjust > the current callers in cmd_fetch and update-clone. >

[RFC PATCH 01/10] config: make config_from_gitmodules generally useful

The config_from_gitmodules() function is a good candidate for a centralized point where to read the gitmodules configuration file. Add a repo argument to it to make the function more general, and adjust the current callers in cmd_fetch and update-clone. As a proof of the utility of the change,