Re: [RFC PATCH 2/6] tree-walk: Add three new gentle helpers

2018-07-18 Thread Paul-Sebastian Ungureanu
Hello, On 17.07.2018 21:55, Junio C Hamano wrote: I wonder if the GENTLY option should apply to update_tree_entry() the same way as it would to the other codepaths that currently die to express "we were handed this string by the caller and told to give back object ID the string represents, and w

Re: [RFC PATCH 2/6] tree-walk: Add three new gentle helpers

2018-07-17 Thread Junio C Hamano
Paul-Sebastian Ungureanu writes: > Add `get_tree_entry_gently()`, `find_tree_entry_gently()` > and `get_tree_entry_follow_symlinks_gently()`, which will > make `get_oid()` to be more gently. > > Since `get_tree_entry()` is used in more than 20 places, > adding a new parameter will make this commi

[RFC PATCH 2/6] tree-walk: Add three new gentle helpers

2018-07-17 Thread Paul-Sebastian Ungureanu
Add `get_tree_entry_gently()`, `find_tree_entry_gently()` and `get_tree_entry_follow_symlinks_gently()`, which will make `get_oid()` to be more gently. Since `get_tree_entry()` is used in more than 20 places, adding a new parameter will make this commit harder to read. In every place it is called