[RFC PATCH v2 2/2] bisect: add "edit" command

[Adam Dinwoodie]

Add an "edit" command to git bisect, which will save the current
bisection log to a file, open an editor to allow the user to replay the
bisection log, then replay the edited log file.

This can already be done as separate steps, and doing so is described in
the bisect documentation; this commit merely reduces those separate
steps to a single step.

Signed-off-by: Adam Dinwoodie <a...@dinwoodie.org>
---
 builtin/bisect--helper.c |  3 ++-
 git-bisect.sh            | 18 ++++++++++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 4b5fadcbe..980e3e09b 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -46,7 +46,8 @@ static int check_term_format(const char *term, const char 
*orig_term)
                return error(_("'%s' is not a valid term"), term);
 
        if (one_of(term, "help", "start", "skip", "next", "reset",
-                       "visualize", "view", "replay", "log", "run", "terms", 
NULL))
+                       "visualize", "view", "replay", "log", "edit", "run",
+                       "terms", NULL))
                return error(_("can't use the builtin command '%s' as a term"), 
term);
 
        /*
diff --git a/git-bisect.sh b/git-bisect.sh
index 895d7976a..bcc02a3f2 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -26,6 +26,8 @@ git bisect replay <logfile>
        replay bisection log.
 git bisect log
        show bisect log.
+git bisect edit
+       edit and replay bisect log.
 git bisect run <cmd>...
        use <cmd>... to automatically bisect.
 
@@ -454,6 +456,20 @@ bisect_replay_file() {
        done <"$file"
 }
 
+bisect_edit () {
+       test -s "$GIT_DIR/BISECT_LOG" || die "$(gettext "We are not 
bisecting.")"
+       cp "$GIT_DIR/BISECT_LOG" "$GIT_DIR/BISECT_LOG_EDIT"
+       git_editor "$GIT_DIR/BISECT_LOG_EDIT" ||
+               die "$(gettext "Could not execute editor")"
+       test -n "$(git stripspace --strip-comments 
<"$GIT_DIR/BISECT_LOG_EDIT")" ||
+               die "$(gettext "Nothing to do")"
+       git bisect--helper --bisect-clean-state ||
+               die "$(gettext "Unable to clean repository")"
+       bisect_replay_file "$GIT_DIR/BISECT_LOG_EDIT"
+       rm -f "$GIT_DIR/BISECT_LOG_EDIT"
+       bisect_auto_next
+}
+
 bisect_run () {
        bisect_next_check fail
 
@@ -625,6 +641,8 @@ case "$#" in
                bisect_replay "$@" ;;
        log)
                bisect_log ;;
+       edit)
+               bisect_edit ;;
        run)
                bisect_run "$@" ;;
        terms)
-- 
2.15.0.281.g87c0a7615