Re: [RFC PATCH v3 2/2] t7406: add test for non-default branch in submodule

Hi Eddy, > I suspect that in the tests, because the "server side" repos are > local, the git fetch-by-sha1/cloning by hash will be done correctly, > without the need of a branch hint, but the problem will still exist > for servers such as github which do not support fetch-by-sha1. > In case I

Re: [RFC PATCH v3 2/2] t7406: add test for non-default branch in submodule

2018-04-05 0:41 GMT+03:00 Stefan Beller : > On Wed, Apr 4, 2018 at 1:37 PM, Eddy Petrișor wrote: > >>> you plan to later submit as one patch including both the change as well as >>> the test. >> >> Yes, I did not forget about having a single patch.

Re: [RFC PATCH v3 2/2] t7406: add test for non-default branch in submodule

On Wed, Apr 4, 2018 at 1:37 PM, Eddy Petrișor wrote: >> This patch only contains the test, I presume this goes on top of >> https://public-inbox.org/git/20180403222053.23132-1-eddy.petri...@codeaurora.org/ >> which you plan to later submit as one patch including both the

Re: [RFC PATCH v3 2/2] t7406: add test for non-default branch in submodule

2018-04-04 21:36 GMT+03:00 Stefan Beller : > On Tue, Apr 3, 2018 at 3:26 PM, Eddy Petrișor wrote: >> Notes: >> I am aware this test is not probably the best one and maybe I >> should have first one test that does a one level non-default, before >>

Re: [RFC PATCH v3 2/2] t7406: add test for non-default branch in submodule

On Tue, Apr 3, 2018 at 3:26 PM, Eddy Petrișor wrote: > Notes: > I am aware this test is not probably the best one and maybe I > should have first one test that does a one level non-default, before > trying a test with 2 levels of submodules, but I wanted to express

Re: [RFC PATCH v3 2/2] t7406: add test for non-default branch in submodule

Notes: I am aware this test is not probably the best one and maybe I should have first one test that does a one level non-default, before trying a test with 2 levels of submodules, but I wanted to express the goal of the patch. Currently the test fails, so I am obviously missing

[RFC PATCH v3 2/2] t7406: add test for non-default branch in submodule

From: Eddy Petrișor If a submodule uses a non-default branch and the branch info is versioned, on submodule update --recursive --init the correct branch should be checked out. Signed-off-by: Eddy Petrișor --- t/t7406-submodule-update.sh | 54