Re: [RFC PATCH v3 2/4] branch: re-order function arguments to group related arguments

2017-11-12 Thread Kaartic Sivaraam
On Mon, 2017-11-13 at 11:32 +0900, Junio C Hamano wrote: > Kaartic Sivaraam writes: > > > I've tried to improve it, does the following paragraph sound clear > > enough? > > > > branch: group related arguments of create_branch() > > > > New arguments were added to create_branch()

Re: [RFC PATCH v3 2/4] branch: re-order function arguments to group related arguments

2017-11-12 Thread Junio C Hamano
Kaartic Sivaraam writes: > I've tried to improve it, does the following paragraph sound clear > enough? > > branch: group related arguments of create_branch() > > New arguments were added to create_branch() whenever the need > arised and they were added to tail of the argumen

Re: [RFC PATCH v3 2/4] branch: re-order function arguments to group related arguments

2017-11-12 Thread Kaartic Sivaraam
On Mon, 2017-11-06 at 11:06 +0900, Junio C Hamano wrote: > Kaartic Sivaraam writes: > > > From: Kaartic Sivaraam > > > > The ad-hoc patches to add new arguments to a function when needed > > resulted in the related arguments not being close to each other. > > This misleads the person reading th

Re: [RFC PATCH v3 2/4] branch: re-order function arguments to group related arguments

2017-11-05 Thread Junio C Hamano
Kaartic Sivaraam writes: > From: Kaartic Sivaraam > > The ad-hoc patches to add new arguments to a function when needed > resulted in the related arguments not being close to each other. > This misleads the person reading the code to believe that there isn't > much relation between those argumen

[RFC PATCH v3 2/4] branch: re-order function arguments to group related arguments

2017-11-01 Thread Kaartic Sivaraam
From: Kaartic Sivaraam The ad-hoc patches to add new arguments to a function when needed resulted in the related arguments not being close to each other. This misleads the person reading the code to believe that there isn't much relation between those arguments while it's not the case. So, re-or

[RFC PATCH v3 2/4] branch: re-order function arguments to group related arguments

2017-11-01 Thread Kaartic Sivaraam
From: Kaartic Sivaraam The ad-hoc patches to add new arguments to a function when needed resulted in the related arguments not being close to each other. This misleads the person reading the code to believe that there isn't much relation between those arguments while it's not the case. So, re-or