Re: [RFC PATCH v3 4/4] builtin/branch: give more useful error messages when renaming

2017-11-13 Thread Kaartic Sivaraam
On Monday 13 November 2017 05:00 PM, Kevin Daudt wrote: On Mon, Nov 13, 2017 at 08:01:12AM +0530, Kaartic Sivaraam wrote: That was a little attribution I wanted make to the strbuf API as this was the first time I leveraged it to this extent and I was surprised by the way it made string

Re: [RFC PATCH v3 4/4] builtin/branch: give more useful error messages when renaming

2017-11-13 Thread Kevin Daudt
On Mon, Nov 13, 2017 at 08:01:12AM +0530, Kaartic Sivaraam wrote: > On Sunday 12 November 2017 11:53 PM, Kevin Daudt wrote: > > On Thu, Nov 02, 2017 at 12:24:07PM +0530, Kaartic Sivaraam wrote: > > > From: Kaartic Sivaraam > > > > > > When trying to rename an

Re: [RFC PATCH v3 4/4] builtin/branch: give more useful error messages when renaming

2017-11-12 Thread Kaartic Sivaraam
On Sunday 12 November 2017 11:53 PM, Kevin Daudt wrote: On Thu, Nov 02, 2017 at 12:24:07PM +0530, Kaartic Sivaraam wrote: From: Kaartic Sivaraam When trying to rename an inexistent branch to with a name of a branch This sentence does not read well. Probably

Re: [RFC PATCH v3 4/4] builtin/branch: give more useful error messages when renaming

2017-11-12 Thread Kevin Daudt
On Thu, Nov 02, 2017 at 12:24:07PM +0530, Kaartic Sivaraam wrote: > From: Kaartic Sivaraam > > When trying to rename an inexistent branch to with a name of a branch This sentence does not read well. Probably s/with a/the/ helps. > that already exists the rename

Re: [RFC PATCH v3 4/4] builtin/branch: give more useful error messages when renaming

2017-11-12 Thread Kaartic Sivaraam
On Mon, 2017-11-06 at 11:30 +0900, Junio C Hamano wrote: > Kaartic Sivaraam writes: > > No {} around a single statement block of "if", especially when there > is no "else" that has multi-statement block that needs {}. > The code has changed a little since v3 so this

Re: [RFC PATCH v3 4/4] builtin/branch: give more useful error messages when renaming

2017-11-05 Thread Junio C Hamano
Kaartic Sivaraam writes: > diff --git a/builtin/branch.c b/builtin/branch.c > index 7018e5d75..c2bbf8c3d 100644 > --- a/builtin/branch.c > +++ b/builtin/branch.c > @@ -458,11 +458,42 @@ static void reject_rebase_or_bisect_branch(const char > *target) >

Re: [RFC PATCH v3 4/4] builtin/branch: give more useful error messages when renaming

2017-11-02 Thread Kaartic Sivaraam
On Thursday 02 November 2017 07:51 PM, Eric Sunshine wrote: Nicely explained; easily understood. Good to hear that. Translators can correct me, but this smells like "sentence lego"[1], which we'd like to avoid. Translators lack full context when presented with bits and pieces of a

Re: [RFC PATCH v3 4/4] builtin/branch: give more useful error messages when renaming

2017-11-02 Thread Eric Sunshine
On Thu, Nov 2, 2017 at 2:54 AM, Kaartic Sivaraam wrote: > From: Kaartic Sivaraam > > When trying to rename an inexistent branch to with a name of a branch > that already exists the rename failed specifying the new branch name > exists

[RFC PATCH v3 4/4] builtin/branch: give more useful error messages when renaming

2017-11-02 Thread Kaartic Sivaraam
From: Kaartic Sivaraam When trying to rename an inexistent branch to with a name of a branch that already exists the rename failed specifying the new branch name exists rather than specifying that the branch trying to be renamed doesn't exist. $ git branch -m

[RFC PATCH v3 4/4] builtin/branch: give more useful error messages when renaming

2017-11-02 Thread Kaartic Sivaraam
From: Kaartic Sivaraam When trying to rename an inexistent branch to with a name of a branch that already exists the rename failed specifying the new branch name exists rather than specifying that the branch trying to be renamed doesn't exist. $ git branch -m