Re: [RFC PATCH v4 1/3] Add support for nested aliases

2018-09-21 Thread Junio C Hamano
Tim Schumacher writes: > it is located at the top of the while() loop. Giving an example is nice, but > wouldn't > it be better to say something like the following? > > /* >* Check if av[0] is a command before seeing if it is an >* alias to avoid taking over existing

Re: [RFC PATCH v4 1/3] Add support for nested aliases

2018-09-21 Thread Tim Schumacher
On 17.09.18 17:37, Junio C Hamano wrote: Tim Schumacher writes: On 08.09.18 15:28, Duy Nguyen wrote: On Sat, Sep 8, 2018 at 12:44 AM Tim Schumacher wrote: + /* +* It could be an alias -- this works around the insanity * of overriding "git

Re: [RFC PATCH v4 1/3] Add support for nested aliases

2018-09-17 Thread Junio C Hamano
Tim Schumacher writes: > On 08.09.18 15:28, Duy Nguyen wrote: >> On Sat, Sep 8, 2018 at 12:44 AM Tim Schumacher wrote: >>> + /* >>> +* It could be an alias -- this works around the insanity >>> * of overriding "git log" with "git show" by having

Re: [RFC PATCH v4 1/3] Add support for nested aliases

2018-09-16 Thread Tim Schumacher
On 08.09.18 15:28, Duy Nguyen wrote: On Sat, Sep 8, 2018 at 12:44 AM Tim Schumacher wrote: + /* +* It could be an alias -- this works around the insanity * of overriding "git log" with "git show" by having * alias.log = show

Re: [RFC PATCH v4 1/3] Add support for nested aliases

2018-09-08 Thread Duy Nguyen
On Sat, Sep 8, 2018 at 12:44 AM Tim Schumacher wrote: > + /* > +* It could be an alias -- this works around the insanity > * of overriding "git log" with "git show" by having > * alias.log = show > */ I think this

[RFC PATCH v4 1/3] Add support for nested aliases

2018-09-07 Thread Tim Schumacher
Aliases can only contain non-alias git commands and their arguments, not other user-defined aliases. Resolving further (nested) aliases is prevented by breaking the loop after the first alias was processed. Git then fails with a command-not-found error. Allow resolving nested aliases by not