RE: [RFC PATCHv2 15/17] checkout: recurse into submodules if asked to

2016-12-05 Thread David Turner
ject: [RFC PATCHv2 15/17] checkout: recurse into submodules if asked to > > Allow checkout to recurse into submodules via the command line option -- > [no-]recurse-submodules. This option probably needs to precede 9/17 "update submodules: add scheduling to update submodules", since that patch uses --recurse-submodules.

Re: [RFC PATCHv2 15/17] checkout: recurse into submodules if asked to

2016-12-05 Thread Brandon Williams
On 12/05, Stefan Beller wrote: > On Mon, Dec 5, 2016 at 11:25 AM, Brandon Williams wrote: > > On 12/02, Stefan Beller wrote: > >> > >> test_expect_success '"checkout " honors diff.ignoreSubmodules' > >> ' > >> @@ -63,6 +70,260 @@ test_expect_success '"checkout " honors > >>

Re: [RFC PATCHv2 15/17] checkout: recurse into submodules if asked to

2016-12-05 Thread Stefan Beller
On Mon, Dec 5, 2016 at 11:25 AM, Brandon Williams wrote: > On 12/02, Stefan Beller wrote: >> >> test_expect_success '"checkout " honors diff.ignoreSubmodules' ' >> @@ -63,6 +70,260 @@ test_expect_success '"checkout " honors >> submodule.*.ignore from .git/ >> ! test -s

Re: [RFC PATCHv2 15/17] checkout: recurse into submodules if asked to

2016-12-05 Thread Brandon Williams
On 12/02, Stefan Beller wrote: > > test_expect_success '"checkout " honors diff.ignoreSubmodules' ' > @@ -63,6 +70,260 @@ test_expect_success '"checkout " honors > submodule.*.ignore from .git/ > ! test -s actual > ' Should you use test_must_fail and not '!'? -- Brandon Williams

[RFC PATCHv2 15/17] checkout: recurse into submodules if asked to

2016-12-02 Thread Stefan Beller
Allow checkout to recurse into submodules via the command line option --[no-]recurse-submodules. The flag for recurse-submodules in its current form could be an OPT_BOOL, but eventually we may want to have it as: git checkout --recurse-submodules=rebase|merge| \