Re: [WIP/PATCH v5 03/10] for-each-ref: rename 'refinfo' to 'ref_array_item'

2015-06-08 Thread Karthik Nayak
On 06/08/2015 08:12 PM, Matthieu Moy wrote: Karthik Nayak karthik@gmail.com writes: Make 'symref' a non const char pointer, so that the compiler doesn't throw an error when we try to free the memory allocated to it. Casting to non-cost when calling free() is a common pattern. I think it

Re: [WIP/PATCH v5 03/10] for-each-ref: rename 'refinfo' to 'ref_array_item'

2015-06-08 Thread Matthieu Moy
Karthik Nayak karthik@gmail.com writes: Make 'symref' a non const char pointer, so that the compiler doesn't throw an error when we try to free the memory allocated to it. Casting to non-cost when calling free() is a common pattern. I think it would make more sense to cast at free() time

[WIP/PATCH v5 03/10] for-each-ref: rename 'refinfo' to 'ref_array_item'

2015-06-06 Thread Karthik Nayak
Rename 'refinfo' to 'ref_array_item' as a preparatory step for introduction of new structures in the forthcoming patch. Re-order the fields in 'ref_array_item' so that refname can be eventually converted to a FLEX_ARRAY. Make 'symref' a non const char pointer, so that the compiler doesn't throw