Re: Bug: send-pack does not respect http.signingkey

2015-07-21 Thread Dave Borowitz
On Thu, Jul 16, 2015 at 3:08 PM, Dave Borowitz dborow...@google.com wrote: On Thu, Jul 16, 2015 at 2:10 PM, Junio C Hamano gits...@pobox.com wrote: Dave Borowitz dborow...@google.com writes: On Thu, Jul 16, 2015 at 1:12 PM, Junio C Hamano gits...@pobox.com wrote: Dave Borowitz

Re: Bug: send-pack does not respect http.signingkey

2015-07-21 Thread Junio C Hamano
Dave Borowitz dborow...@google.com writes: Should I formally send a patch with your configuration one-liner? Yeah, the log message, that explains the motivation of the change and the decision to read which part of the configuration, is much more important than the actual patch, so please do so

Re: Bug: send-pack does not respect http.signingkey

2015-07-16 Thread Junio C Hamano
Dave Borowitz dborow...@google.com writes: When git-send-pack is exec'ed, as is done by git-remote-http, it does not reread the config, so it does not respect the configured http.signingkey, either from the config file or -c on the command line. Thus it is currently impossible to specify a

Re: Bug: send-pack does not respect http.signingkey

2015-07-16 Thread Junio C Hamano
Dave Borowitz dborow...@google.com writes: On Thu, Jul 16, 2015 at 1:06 PM, Junio C Hamano gits...@pobox.com wrote: Perhaps something like this? Seems like it should work. Jonathan had suggested there might be some principled reason why send-pack does not respect config options, and

Bug: send-pack does not respect http.signingkey

2015-07-16 Thread Dave Borowitz
When git-send-pack is exec'ed, as is done by git-remote-http, it does not reread the config, so it does not respect the configured http.signingkey, either from the config file or -c on the command line. Thus it is currently impossible to specify a signing key over HTTP, other than the default one

Re: Bug: send-pack does not respect http.signingkey

2015-07-16 Thread Dave Borowitz
On Thu, Jul 16, 2015 at 1:12 PM, Junio C Hamano gits...@pobox.com wrote: Dave Borowitz dborow...@google.com writes: On Thu, Jul 16, 2015 at 1:06 PM, Junio C Hamano gits...@pobox.com wrote: Perhaps something like this? Seems like it should work. Jonathan had suggested there might be some

Re: Bug: send-pack does not respect http.signingkey

2015-07-16 Thread Junio C Hamano
Dave Borowitz dborow...@google.com writes: On Thu, Jul 16, 2015 at 1:12 PM, Junio C Hamano gits...@pobox.com wrote: Dave Borowitz dborow...@google.com writes: On Thu, Jul 16, 2015 at 1:06 PM, Junio C Hamano gits...@pobox.com wrote: Perhaps something like this? Seems like it should work.

Re: Bug: send-pack does not respect http.signingkey

2015-07-16 Thread Dave Borowitz
On Thu, Jul 16, 2015 at 1:06 PM, Junio C Hamano gits...@pobox.com wrote: Dave Borowitz dborow...@google.com writes: When git-send-pack is exec'ed, as is done by git-remote-http, it does not reread the config, so it does not respect the configured http.signingkey, either from the config file

Re: Bug: send-pack does not respect http.signingkey

2015-07-16 Thread Dave Borowitz
On Thu, Jul 16, 2015 at 2:10 PM, Junio C Hamano gits...@pobox.com wrote: Dave Borowitz dborow...@google.com writes: On Thu, Jul 16, 2015 at 1:12 PM, Junio C Hamano gits...@pobox.com wrote: Dave Borowitz dborow...@google.com writes: On Thu, Jul 16, 2015 at 1:06 PM, Junio C Hamano