Re: Bug report: $program_name in error message

2016-12-20 Thread Junio C Hamano
Vasco Almeida writes: > Thanks for the report and letting me know. > Yes, these were mistakes and lack of attention mine. It was supposed to > call 'eval_gettext' rather than 'gettext' when \$variable interpolation > is needed. Thanks. As both of the offending commits

Re: Bug report: $program_name in error message

2016-12-20 Thread Vasco Almeida
Thanks for the report and letting me know. Yes, these were mistakes and lack of attention mine. It was supposed to call 'eval_gettext' rather than 'gettext' when \$variable interpolation is needed. Junio Hamano has the right answer for these errors. A Seg, 19-12-2016 às 12:50 -0800, Junio C

Re: Bug report: $program_name in error message

2016-12-19 Thread Stefan Beller
On Mon, Dec 19, 2016 at 12:50 PM, Junio C Hamano wrote: > > -- >8 -- > Subject: rebase -i: fix mistaken i18n > > f2d17068fd ("i18n: rebase-interactive: mark comments of squash for > translation", 2016-06-17) attempted to apply sh-i18n and failed to > use $(eval_gettext "string

Re: Bug report: $program_name in error message

2016-12-19 Thread Junio C Hamano
Junio C Hamano writes: > Comparing these changes that involve "\$variable" ... > > dashless=$(basename -- "$0" | sed -e 's/-/ /') > usage() { > - die "usage: $dashless $USAGE" > + die "$(eval_gettext "usage: \$dashless \$USAGE")" > ... and

Re: Bug report: $program_name in error message

2016-12-19 Thread Junio C Hamano
Stefan Beller writes: > + Vasco Almeida, who authored d323c6b641, > (i18n: git-sh-setup.sh: mark strings for translation, 2016-06-17) Comparing these changes that involve "\$variable" ... diff --git a/git-sh-setup.sh b/git-sh-setup.sh index c48139a494..2eda134800 100644 ---

Re: Bug report: $program_name in error message

2016-12-19 Thread Stefan Beller
+ Vasco Almeida, who authored d323c6b641, (i18n: git-sh-setup.sh: mark strings for translation, 2016-06-17) On Sun, Dec 18, 2016 at 1:44 PM, Josh Bleecher Snyder wrote: >>> To reproduce, run 'git submodule' from within a bare repo. Result: >>> >>> $ git submodule >>> fatal:

Re: Bug report: $program_name in error message

2016-12-18 Thread Josh Bleecher Snyder
>> To reproduce, run 'git submodule' from within a bare repo. Result: >> >> $ git submodule >> fatal: $program_name cannot be used without a working tree. >> >> Looks like the intent was for $program_name to be interpolated. > > Which version of git do you use? $ git version git version 2.11.0

Re: Bug report: $program_name in error message

2016-12-18 Thread Stefan Beller
On Sun, Dec 18, 2016 at 12:36 PM, Josh Bleecher Snyder wrote: > To reproduce, run 'git submodule' from within a bare repo. Result: > > $ git submodule > fatal: $program_name cannot be used without a working tree. > > Looks like the intent was for $program_name to be

Bug report: $program_name in error message

2016-12-18 Thread Josh Bleecher Snyder
To reproduce, run 'git submodule' from within a bare repo. Result: $ git submodule fatal: $program_name cannot be used without a working tree. Looks like the intent was for $program_name to be interpolated. As an aside, I sent a message a few days ago about a segfault when working with a