Re: Clone from shallow bundle bug

2015-04-01 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 04/01/2015 08:33 PM, Duy Nguyen wrote: > OK two additional options on top of what we already have: > > - save .have and add extra prerequisite SHA-1. - create a bundle > that does not hit shallow boundary in the first place, roughly > speaking it

Re: Clone from shallow bundle bug

2015-04-01 Thread Duy Nguyen
On Thu, Apr 2, 2015 at 7:33 AM, Duy Nguyen wrote: > OK two additional options on top of what we already have: > > - save .have and add extra prerequisite SHA-1. > - create a bundle that does not hit shallow boundary in the first > place, roughly speaking it's "max depth minus one". This one does

Re: Clone from shallow bundle bug

2015-04-01 Thread Duy Nguyen
On Thu, Apr 2, 2015 at 12:20 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> Alternatively, we can record SHA-1 in the shallow file as refs whose >> name is always ".shallow". This way "unbundle" can recreate the >> shallow file if it wants. > > Wouldn't the extracting end care about such a n

Re: Clone from shallow bundle bug

2015-04-01 Thread Junio C Hamano
Duy Nguyen writes: > Alternatively, we can record SHA-1 in the shallow file as refs whose > name is always ".shallow". This way "unbundle" can recreate the > shallow file if it wants. Wouldn't the extracting end care about such a name ".shallow" being duplicates (if you have multiple boundaries)

Re: Clone from shallow bundle bug

2015-04-01 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 4/1/2015 9:36 AM, Duy Nguyen wrote: > Thank you. I can reproduce it now. We need to plug this hole. I'd much rather it not refuse to clone so that I can end up with a proper shallow clone. At least the way it is now, when I clone the detached head

Re: Clone from shallow bundle bug

2015-04-01 Thread Duy Nguyen
On Wed, Apr 1, 2015 at 8:30 PM, Phillip Susi wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 4/1/2015 9:09 AM, Duy Nguyen wrote: >>> Strange; it works fine for me using git 1.9.4.msysgit.1, and then >>> I just get the complaints from gitk. I created the bundle with >>> no prereq a

Re: Clone from shallow bundle bug

2015-04-01 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 4/1/2015 9:09 AM, Duy Nguyen wrote: >> Strange; it works fine for me using git 1.9.4.msysgit.1, and then >> I just get the complaints from gitk. I created the bundle with >> no prereq argument, i.e. "git bundle create shallow.bundle". Did >> you u

Re: Clone from shallow bundle bug

2015-04-01 Thread Duy Nguyen
On Wed, Apr 1, 2015 at 7:53 PM, Phillip Susi wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 4/1/2015 5:55 AM, Duy Nguyen wrote: >> On Wed, Apr 1, 2015 at 4:10 AM, Phillip Susi >> wrote: >>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >>> >>> I made a shallow clone of my repo, t

Re: Clone from shallow bundle bug

2015-04-01 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 4/1/2015 6:01 AM, Duy Nguyen wrote: > On Wed, Apr 1, 2015 at 1:31 PM, Junio C Hamano > wrote: >> The only way a bundle can record "something" "noting" that it is >> an incomplete history, while allowing it to be read by existing >> implementations

Re: Clone from shallow bundle bug

2015-04-01 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 4/1/2015 5:55 AM, Duy Nguyen wrote: > On Wed, Apr 1, 2015 at 4:10 AM, Phillip Susi > wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> I made a shallow clone of my repo, then used git bundle create to >> pack it all into a bundle file,

Re: Clone from shallow bundle bug

2015-04-01 Thread Duy Nguyen
On Wed, Apr 1, 2015 at 1:31 PM, Junio C Hamano wrote: > The only way a bundle can record "something" "noting" that it is an > incomplete history, while allowing it to be read by existing > implementations of "git bundle unbundle" is to list the commits, > behind which there is no history available

Re: Clone from shallow bundle bug

2015-04-01 Thread Duy Nguyen
On Wed, Apr 1, 2015 at 4:10 AM, Phillip Susi wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > I made a shallow clone of my repo, then used git bundle create to pack > it all into a bundle file, then cloned from that bundle. The initial > shallow clone has a .git/shallow file that iden

Re: Clone from shallow bundle bug

2015-03-31 Thread Junio C Hamano
Phillip Susi writes: > On 03/31/2015 06:17 PM, Junio C Hamano wrote: >> Phillip Susi writes: >> >>> I made a shallow clone of my repo, then used git bundle create to >>> pack it all into a bundle file, then cloned from that bundle. >> >> I think the introdution of shallow clone feature broke g

Re: Clone from shallow bundle bug

2015-03-31 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 03/31/2015 06:17 PM, Junio C Hamano wrote: > Phillip Susi writes: > >> I made a shallow clone of my repo, then used git bundle create to >> pack it all into a bundle file, then cloned from that bundle. > > I think the introdution of shallow clo

Re: Clone from shallow bundle bug

2015-03-31 Thread Junio C Hamano
Phillip Susi writes: > I made a shallow clone of my repo, then used git bundle create to pack > it all into a bundle file, then cloned from that bundle. I think the introdution of shallow clone feature broke git bundle create by not teaching it that its shallow boundaries are prerequisite commit

Clone from shallow bundle bug

2015-03-31 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I made a shallow clone of my repo, then used git bundle create to pack it all into a bundle file, then cloned from that bundle. The initial shallow clone has a .git/shallow file that identifies it as a shallow clone ( and I guess keeps things from com