On Wed, Apr 10, 2013 at 11:00 PM, Jens Lehmann <jens.lehm...@web.de> wrote: > > Am 10.04.2013 20:24, schrieb Orgad Shaneh: > > Executes checkout without -q > > Nice, looks like you picked the proposal I made last September: > http://permalink.gmane.org/gmane.comp.version-control.git/204747
Took me a while, but I finally got to it :) > The change is looking good, but you still need to document the > new option in Documentation/git-submodule.txt too please. > > And the commit message is still too short, as I said in that > other thread: > > On Tue, Sep 4, 2012 at 6:28 PM, Jens Lehmann <jens.lehm...@web.de> wrote: > > Before the "Signed-off-by" is the place where you should have > > explained why this would be a worthwhile change ;-) > > And you answered to that with something that would really make > sense as first part of the commit message, because you explain > *why* you do that change: > > Am 05.09.2012 13:42, schrieb Orgad and Raizel Shaneh: > > When I run 'git submodule update' I don't expect to be in the dark > > until the submodule/s finishes checkout, this sometimes can take a > > significant amount of time and feedback is expected. > > Another paragraph after that should explain *how* you do it. > > So what about the following as commit message: > -------------------------------------------------------------- > When 'git submodule add/update' is run there is no output during > checkout. This can take a significant amount of time and it would > be nice if user could enable some feedback to see what's going on. > > Add the -v/--verbose option to both add and update which suppresses > the -q normally given to checkout so the user sees progress output > from the checkout command. > > <Your Signed-off-by goes here> > -------------------------------------------------------------- > > I'm looking forward to your next iteration. Done quicker this time ;-) Thanks a lot for your review (previous and current). It was very helpful! - Orgad -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
