Re: Hardcoded #!/bin/sh in t5532 causes problems on Solaris

On Tue, Apr 12, 2016 at 10:12:39AM -0700, Junio C Hamano wrote: > In any case, lest we forget... > > -- >8 -- > Subject: [PATCH] t3404: use write_script Yep, looks good. Thanks. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to

Re: Hardcoded #!/bin/sh in t5532 causes problems on Solaris

On Tue, Apr 12, 2016 at 09:58:20AM -0700, Junio C Hamano wrote: > > Looks good and is the minimal change. I kind of wonder if the example > > would be more clear, though, as just: > > > > write_script .git/hooks/pre-commit <<-\EOF && > > exit 1 > > EOF > > echo whatever >file1 && > >

Re: Hardcoded #!/bin/sh in t5532 causes problems on Solaris

Junio C Hamano writes: > Jeff King writes: > ... >> Looks good and is the minimal change. I kind of wonder if the example >> would be more clear, though, as just: >> >> write_script .git/hooks/pre-commit <<-\EOF && >> exit 1 >> EOF >> echo whatever

Re: Hardcoded #!/bin/sh in t5532 causes problems on Solaris

Jeff King writes: > On Sat, Apr 09, 2016 at 05:37:43PM -0700, Junio C Hamano wrote: > >> diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh >> index b79f442..d96d0e4 100755 >> --- a/t/t3404-rebase-interactive.sh >> +++ b/t/t3404-rebase-interactive.sh >> @@

Re: Hardcoded #!/bin/sh in t5532 causes problems on Solaris

On Sat, Apr 09, 2016 at 05:37:43PM -0700, Junio C Hamano wrote: > diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh > index b79f442..d96d0e4 100755 > --- a/t/t3404-rebase-interactive.sh > +++ b/t/t3404-rebase-interactive.sh > @@ -555,10 +555,9 @@ test_expect_success

Re: Hardcoded #!/bin/sh in t5532 causes problems on Solaris

On Sun, Apr 10, 2016 at 12:01:30PM -0700, Junio C Hamano wrote: > > diff --git a/t/t1020-subdirectory.sh b/t/t1020-subdirectory.sh > > index 8e22b03..6dedb1c 100755 > > --- a/t/t1020-subdirectory.sh > > +++ b/t/t1020-subdirectory.sh > > @@ -142,9 +142,9 @@ test_expect_success 'GIT_PREFIX for

Re: Hardcoded #!/bin/sh in t5532 causes problems on Solaris

Eric Sunshine writes: >> with "printf". The output from the latter is compared with an >> expected output, again prepared with "printf" hance lacking the > > s/hance/hence/ Thanks -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a

Re: Hardcoded #!/bin/sh in t5532 causes problems on Solaris

On Sun, Apr 10, 2016 at 3:01 PM, Junio C Hamano wrote: > Subject: t1020: do not overuse printf and use write_script > > The test prepares a sample file "dir/two" with a single incomplete > line in it with "printf", and also prepares a small helper script > "diff" to create a

Re: Hardcoded #!/bin/sh in t5532 causes problems on Solaris

Junio C Hamano writes: > I looked at > > $ git grep -c '#! */bin/sh' t | grep -v ':1$' > > and did a few just for fun. Doing it fully may be a good > microproject for next year ;-) > > t/t1020-subdirectory.sh | 6 +++--- > t/t2050-git-dir-relative.sh | 11

Re: Hardcoded #!/bin/sh in t5532 causes problems on Solaris

Jeff King writes: > Hmm. t3404.40 does this: > > echo "#!/bin/sh" > $PRE_COMMIT && > echo "test -z \"\$(git diff --cached --check)\"" >>$PRE_COMMIT && > chmod a+x $PRE_COMMIT && > > So I'm pretty sure that $PRE_COMMIT script should be barfing each time > it is

Re: Hardcoded #!/bin/sh in t5532 causes problems on Solaris

On Sun, Apr 10, 2016 at 12:29:45AM +0200, Tom G. Christensen wrote: > On 09/04/16 23:04, Jeff King wrote: > >I did some quick grepping around, and I suspect you may run > >into the same thing in other places (e.g., t3404.40 looks > >like a similar case). > > There are only a few tests that fail

Re: Hardcoded #!/bin/sh in t5532 causes problems on Solaris

On 09/04/16 23:04, Jeff King wrote: I did some quick grepping around, and I suspect you may run into the same thing in other places (e.g., t3404.40 looks like a similar case). There are only a few tests that fail and just t5532.3 seems affected by this issue. Subject: [PATCH] t5532: use

Re: Hardcoded #!/bin/sh in t5532 causes problems on Solaris

On Sat, Apr 09, 2016 at 10:27:37PM +0200, Tom G. Christensen wrote: > Looking at the testsuite results on Solaris I see a failure in t5532.3. > > Running the testsuite with -v -i revealed a shell syntax error: > > proxying for example.com 9418 > ./proxy: syntax error at line 3: `cmd=$'

Hardcoded #!/bin/sh in t5532 causes problems on Solaris

Hello, Looking at the testsuite results on Solaris I see a failure in t5532.3. Running the testsuite with -v -i revealed a shell syntax error: proxying for example.com 9418 ./proxy: syntax error at line 3: `cmd=$' unexpected not ok 3 - fetch through proxy works # # git fetch fake