Re: Improved error handling (Was: [PATCH 1/2] sequencer: factor out rewrite_file())

2017-12-25 Thread Johannes Sixt
Am 24.12.2017 um 15:54 schrieb Jeff King: On Sat, Nov 18, 2017 at 10:01:45AM +0100, Johannes Sixt wrote: Yeah, I have mixed feelings on that. I think it does make the control flow less clear. At the same time, what I found was that handlers like die/ignore/warn were the thing that gave the

RE: Improved error handling (Was: [PATCH 1/2] sequencer: factor out rewrite_file())

2017-12-24 Thread Randall S. Becker
On December 24, 2017 9:54 AM, Jeff King wrote: > Subject: Re: Improved error handling (Was: [PATCH 1/2] sequencer: factor > out rewrite_file()) > > On Sat, Nov 18, 2017 at 10:01:45AM +0100, Johannes Sixt wrote: > > > > Yeah, I have mixed feelings on that. I think it doe

Re: Improved error handling (Was: [PATCH 1/2] sequencer: factor out rewrite_file())

2017-12-24 Thread Jeff King
On Sat, Nov 18, 2017 at 10:01:45AM +0100, Johannes Sixt wrote: > > Yeah, I have mixed feelings on that. I think it does make the control > > flow less clear. At the same time, what I found was that handlers like > > die/ignore/warn were the thing that gave the most reduction in > > complexity in

Re: Improved error handling (Was: [PATCH 1/2] sequencer: factor out rewrite_file())

2017-11-18 Thread Johannes Sixt
Am 17.11.2017 um 23:33 schrieb Jeff King: On Mon, Nov 06, 2017 at 05:13:15PM +0100, Simon Ruderich wrote: On Sat, Nov 04, 2017 at 10:07:00PM -0400, Jeff King wrote: Yes, I think what you've written here (and below) is quite close to the error_context patches I linked elsewhere in the thread.

Re: Improved error handling (Was: [PATCH 1/2] sequencer: factor out rewrite_file())

2017-11-17 Thread Jeff King
On Mon, Nov 06, 2017 at 05:13:15PM +0100, Simon Ruderich wrote: > On Sat, Nov 04, 2017 at 10:07:00PM -0400, Jeff King wrote: > > Yes, I think what you've written here (and below) is quite close to the > > error_context patches I linked elsewhere in the thread. In other > > words, I think it's a

Re: Improved error handling (Was: [PATCH 1/2] sequencer: factor out rewrite_file())

2017-11-16 Thread Simon Ruderich
On Mon, Nov 06, 2017 at 05:13:15PM +0100, Simon Ruderich wrote: > On Sat, Nov 04, 2017 at 10:07:00PM -0400, Jeff King wrote: >> Yes, I think what you've written here (and below) is quite close to the >> error_context patches I linked elsewhere in the thread. In other >> words, I think it's a sane

Re: Improved error handling (Was: [PATCH 1/2] sequencer: factor out rewrite_file())

2017-11-06 Thread Simon Ruderich
On Sat, Nov 04, 2017 at 10:07:00PM -0400, Jeff King wrote: > Yes, I think what you've written here (and below) is quite close to the > error_context patches I linked elsewhere in the thread. In other > words, I think it's a sane approach. In contrast to error_context I'd like to keep all exiting