Re: Issuing warning when hook does not have execution permission

2014-08-20 Thread Junio C Hamano
Jeff King writes: > On Wed, Aug 20, 2014 at 08:55:52PM +1200, Chris Packham wrote: > >> I actually find the existing behaviour useful. If I want to disable a >> hook to I can just chmod -x .git/hook/... and I then chmod +x it when >> I want to re-enable it. I guess I could live with an extra warn

Re: Issuing warning when hook does not have execution permission

2014-08-20 Thread Jeff King
On Wed, Aug 20, 2014 at 08:55:52PM +1200, Chris Packham wrote: > I actually find the existing behaviour useful. If I want to disable a > hook to I can just chmod -x .git/hook/... and I then chmod +x it when > I want to re-enable it. I guess I could live with an extra warning as > long as the comma

Re: Issuing warning when hook does not have execution permission

2014-08-20 Thread Chris Packham
On Wed, Aug 20, 2014 at 4:52 AM, Junio C Hamano wrote: > Jeff King writes: > >> On Tue, Aug 19, 2014 at 04:05:21PM +1000, Babak M wrote: >> >>> I saw that if a hook file is present in .git/hooks and it does not >>> have execution permissions it is silently ignored. >>> >>> I thought it might be w

Re: Issuing warning when hook does not have execution permission

2014-08-19 Thread Junio C Hamano
Jeff King writes: > On Tue, Aug 19, 2014 at 04:05:21PM +1000, Babak M wrote: > >> I saw that if a hook file is present in .git/hooks and it does not >> have execution permissions it is silently ignored. >> >> I thought it might be worthwhile issuing a warning such as "Warning: >> pre-commit hook

Re: Issuing warning when hook does not have execution permission

2014-08-19 Thread Jeff King
On Tue, Aug 19, 2014 at 04:05:21PM +1000, Babak M wrote: > I saw that if a hook file is present in .git/hooks and it does not > have execution permissions it is silently ignored. > > I thought it might be worthwhile issuing a warning such as "Warning: > pre-commit hook exists but it cannot be exe

Issuing warning when hook does not have execution permission

2014-08-18 Thread Babak M
Hi, I saw that if a hook file is present in .git/hooks and it does not have execution permissions it is silently ignored. I thought it might be worthwhile issuing a warning such as "Warning: pre-commit hook exists but it cannot be executed due to insufficient permissions". Not sure if this has b