Re: Possible git blame bug?

2017-03-13 Thread Domagoj Stolfa
Hello, > > Thanks for clearing this up. Is this documented somewhere, so that if it > > happens > > again I can point people to the docs that explain this behaviour? > > Is this from "git blame --help" sufficient? > > When you are not interested in changes older than version > v2.6.18,

Re: Possible git blame bug?

2017-03-13 Thread Junio C Hamano
Domagoj Stolfa writes: > Thanks for clearing this up. Is this documented somewhere, so that if it > happens > again I can point people to the docs that explain this behaviour? Is this from "git blame --help" sufficient? When you are not interested in changes

Re: Possible git blame bug?

2017-03-13 Thread Domagoj Stolfa
Hello, > > For example, saying: > > > > $ git blame time.h --since=2017 > > ^e19f2a27ed8 (Domagoj Stolfa 2017-03-12 20:43:01 +0100 33) #ifndef > > _SYS_TIME_H_ > > > > $ git blame time.h --since=2016 > > ^21613a57af9 (bz 2016-03-13 21:26:18 + 33) #ifndef _SYS_TIME_H_ > > > > $ git blame

Re: Possible git blame bug?

2017-03-13 Thread Junio C Hamano
Junio C Hamano writes: > Domagoj Stolfa writes: > >> For example, saying: >> >> $ git blame time.h --since=2017 >> ^e19f2a27ed8 (Domagoj Stolfa 2017-03-12 20:43:01 +0100 33) #ifndef >> _SYS_TIME_H_ >> >> $ git blame time.h --since=2016 >>

Re: Possible git blame bug?

2017-03-13 Thread Junio C Hamano
Domagoj Stolfa writes: > For example, saying: > > $ git blame time.h --since=2017 > ^e19f2a27ed8 (Domagoj Stolfa 2017-03-12 20:43:01 +0100 33) #ifndef > _SYS_TIME_H_ > > $ git blame time.h --since=2016 > ^21613a57af9 (bz 2016-03-13 21:26:18 + 33) #ifndef

Re: Possible git blame bug?

2017-03-13 Thread Domagoj Stolfa
Hello, > >> The question is whether this is a bug or not, as --since= might not > >> be a > >> valid filter. > > > > I do not think blame ever was designed to work with --since, so that > > is indeed the case. > > Actually, I do see that we had a cut-off based on rev->max_age since we >

Re: Possible git blame bug?

2017-03-13 Thread Junio C Hamano
On Mon, Mar 13, 2017 at 1:38 PM, Junio C Hamano wrote: > Domagoj Stolfa writes: > >> The question is whether this is a bug or not, as --since= might not be >> a >> valid filter. > > I do not think blame ever was designed to work with --since, so that

Re: Possible git blame bug?

2017-03-13 Thread Domagoj Stolfa
Hello, > > The question is whether this is a bug or not, as --since= might not > > be a > > valid filter. > > I do not think blame ever was designed to work with --since, so that > is indeed the case. > > Making it work with --since= might be a worthy addition. > Patches welcome. Thanks

Re: Possible git blame bug?

2017-03-13 Thread Junio C Hamano
Domagoj Stolfa writes: > The question is whether this is a bug or not, as --since= might not be a > valid filter. I do not think blame ever was designed to work with --since, so that is indeed the case. Making it work with --since= might be a worthy addition.

Possible git blame bug?

2017-03-13 Thread Domagoj Stolfa
Hello, yesterday I came across sort of a weird behaviour with git-blame. It would appear when one queries the git blame on a specific file, such as: $ git blame --since= it will blame the entire file on some commit of that year, regardless of the fact whether the commit has actually touched