Re: [PATCH] http: http.emptyauth should allow empty (not just NULL) usernames

2016-10-03 Thread brian m. carlson
On Mon, Oct 03, 2016 at 09:54:19PM +, David Turner wrote: > > > I dunno. The code path you are changing _only_ affects anything if the > > http.emptyauth config is set. But I guess I just don't understand why you > > would say "http://@gitserver; in the first place. Is that a common thing? >

Re: [PATCH] http: http.emptyauth should allow empty (not just NULL) usernames

2016-10-03 Thread Junio C Hamano
David Turner writes: >> > > I dunno. The code path you are changing _only_ affects anything if >> > > the http.emptyauth config is set. But I guess I just don't >> > > understand why you would say "http://@gitserver; in the first place. >> Is that a common thing? >> >

RE: [PATCH] http: http.emptyauth should allow empty (not just NULL) usernames

2016-10-03 Thread David Turner
> -Original Message- > From: Jeff King [mailto:p...@peff.net] > Sent: Monday, October 03, 2016 5:59 PM > To: David Turner > Cc: git@vger.kernel.org; sand...@crustytoothpaste.net > Subject: Re: [PATCH] http: http.emptyauth should allow empty (not just > NULL) username

Re: [PATCH] http: http.emptyauth should allow empty (not just NULL) usernames

2016-10-03 Thread Jeff King
On Mon, Oct 03, 2016 at 09:54:19PM +, David Turner wrote: > > I dunno. The code path you are changing _only_ affects anything if the > > http.emptyauth config is set. But I guess I just don't understand why you > > would say "http://@gitserver; in the first place. Is that a common thing? > >

RE: [PATCH] http: http.emptyauth should allow empty (not just NULL) usernames

2016-10-03 Thread David Turner
> -Original Message- > From: Jeff King [mailto:p...@peff.net] > Sent: Monday, October 03, 2016 5:01 PM > To: David Turner > Cc: git@vger.kernel.org; sand...@crustytoothpaste.net > Subject: Re: [PATCH] http: http.emptyauth should allow empty (not just > NULL) username

Re: [PATCH] http: http.emptyauth should allow empty (not just NULL) usernames

2016-10-03 Thread Jeff King
On Mon, Oct 03, 2016 at 01:19:28PM -0400, David Turner wrote: > When using kerberos authentication, one URL pattern which is > allowed is http://@gitserver.example.com. This leads to a username > of zero-length, rather than a NULL username. But the two cases > should be treated the same by