Re: [PATCH 2/3] merge-recursive: remove return value from get_files_dirs

2017-08-31 Thread Stefan Beller
On Tue, Aug 29, 2017 at 8:58 AM, Kevin Willford wrote: >> >> On Mon, Aug 28, 2017 at 02:28:28PM -0600, Kevin Willford wrote: >> >> > The return value of the get_files_dirs call is never being used. >> > Looking at the history of the file and it was originally only >> > being used for debug output

Re: [PATCH 2/3] merge-recursive: remove return value from get_files_dirs

2017-08-29 Thread Jeff King
On Tue, Aug 29, 2017 at 03:58:00PM +, Kevin Willford wrote: > > > The return value of the get_files_dirs call is never being used. > > > Looking at the history of the file and it was originally only > > > being used for debug output statements. Also when > > > read_tree_recursive return value

RE: [PATCH 2/3] merge-recursive: remove return value from get_files_dirs

2017-08-29 Thread Kevin Willford
> > On Mon, Aug 28, 2017 at 02:28:28PM -0600, Kevin Willford wrote: > > > The return value of the get_files_dirs call is never being used. > > Looking at the history of the file and it was originally only > > being used for debug output statements. Also when > > read_tree_recursive return value

Re: [PATCH 2/3] merge-recursive: remove return value from get_files_dirs

2017-08-29 Thread Jeff King
On Mon, Aug 28, 2017 at 06:45:29PM -0400, Ben Peart wrote: > > Since the debug output has been removed and the caller isn't > > checking the return value there is no reason to keep calulating > > and returning a value. > > > > Did a quick search and you're right, nothing is using the return valu

Re: [PATCH 2/3] merge-recursive: remove return value from get_files_dirs

2017-08-29 Thread Jeff King
On Mon, Aug 28, 2017 at 02:28:28PM -0600, Kevin Willford wrote: > The return value of the get_files_dirs call is never being used. > Looking at the history of the file and it was originally only > being used for debug output statements. Also when > read_tree_recursive return value is non zero it

Re: [PATCH 2/3] merge-recursive: remove return value from get_files_dirs

2017-08-28 Thread Ben Peart
On 8/28/2017 4:28 PM, Kevin Willford wrote: The return value of the get_files_dirs call is never being used. Looking at the history of the file and it was originally only being used for debug output statements. Also when read_tree_recursive return value is non zero it is changed to zero. This