Re: [RFC/PATCH] perl: bump the required Perl version to 5.10.0 from 5.8.0

2017-12-27 Thread Jonathan Nieder
Jonathan Nieder wrote: > Ævar Arnfjörð Bjarmason wrote: >> This is similar to Jeff King's jk/drop-ancient-curl series in that >> we're dropping perl releases that are rarely tested anymore, however >> unlike those patches git still works on e.g. 5.8.8 (I couldn't build >> anything older). [...] >

Re: [RFC/PATCH] perl: bump the required Perl version to 5.10.0 from 5.8.0

2017-12-27 Thread Jonathan Nieder
Hi, Ævar Arnfjörð Bjarmason wrote: > This is similar to Jeff King's jk/drop-ancient-curl series in that > we're dropping perl releases that are rarely tested anymore, however > unlike those patches git still works on e.g. 5.8.8 (I couldn't build > anything older). FWIW I think this is a good cha

Re: [RFC/PATCH] perl: bump the required Perl version to 5.10.0 from 5.8.0

2017-12-27 Thread Junio C Hamano
Eric Wong writes: > Fair enough, I haven't run 5.8 in a while, either. One concern > I have is it makes reviewing more difficult as the language gets > bigger and (even more) unfamiliar constructs pop up. This is > probably more important for git as most of us are not dedicated > Perl hackers.

Re: [RFC/PATCH] perl: bump the required Perl version to 5.10.0 from 5.8.0

2017-12-24 Thread Eric Wong
Ævar Arnfjörð Bjarmason wrote: > I think for any given external dependency of git.git it makes sense to > just pick a version, not say that this script requires perl so-and-so, > this one python so-and-so, or curl/openssl so-and-so etc. Agreed. Any version support changes should be tree-wide. >

Re: [RFC/PATCH] perl: bump the required Perl version to 5.10.0 from 5.8.0

2017-12-24 Thread Ævar Arnfjörð Bjarmason
On Sun, Dec 24 2017, Eric Wong jotted: [Removed Petr Baudis from CC, his suse.cz E-Mail address is bouncing] > Ævar Arnfjörð Bjarmason wrote: >> On Sun, Dec 24 2017, Jeff King jotted: >> > As far as this actual perl change goes, I don't have a strong opinion. I >> > agree it would be nice to e

Re: [RFC/PATCH] perl: bump the required Perl version to 5.10.0 from 5.8.0

2017-12-24 Thread Eric Wong
Ævar Arnfjörð Bjarmason wrote: > On Sun, Dec 24 2017, Jeff King jotted: > > As far as this actual perl change goes, I don't have a strong opinion. I > > agree it would be nice to eventually move forward, and your reasoning > > about what constitutes "old" seems sane. But we also don't write much >

Re: [RFC/PATCH] perl: bump the required Perl version to 5.10.0 from 5.8.0

2017-12-24 Thread Ævar Arnfjörð Bjarmason
On Sun, Dec 24 2017, Jeff King jotted: > On Sat, Dec 23, 2017 at 05:44:00PM +, Ævar Arnfjörð Bjarmason wrote: > >> This is similar to Jeff King's jk/drop-ancient-curl series in that >> we're dropping perl releases that are rarely tested anymore, however >> unlike those patches git still works

Re: [RFC/PATCH] perl: bump the required Perl version to 5.10.0 from 5.8.0

2017-12-24 Thread Jeff King
On Sat, Dec 23, 2017 at 05:44:00PM +, Ævar Arnfjörð Bjarmason wrote: > This is similar to Jeff King's jk/drop-ancient-curl series in that > we're dropping perl releases that are rarely tested anymore, however > unlike those patches git still works on e.g. 5.8.8 (I couldn't build > anything old

Re: [RFC/PATCH] perl: bump the required Perl version to 5.10.0 from 5.8.0

2017-12-24 Thread Ævar Arnfjörð Bjarmason
On Sat, Dec 23 2017, brian m. carlson jotted: > On Sat, Dec 23, 2017 at 05:44:00PM +, Ævar Arnfjörð Bjarmason wrote: >> The reason to do this is to be able to use features released with perl >> in the last decade, 5.10 was a major feature release including things >> like new regex features, s

Re: [RFC/PATCH] perl: bump the required Perl version to 5.10.0 from 5.8.0

2017-12-23 Thread brian m. carlson
On Sat, Dec 23, 2017 at 05:44:00PM +, Ævar Arnfjörð Bjarmason wrote: > The reason to do this is to be able to use features released with perl > in the last decade, 5.10 was a major feature release including things > like new regex features, state variables, the defined-or operator > etc.[3] >

RE: [RFC/PATCH] perl: bump the required Perl version to 5.10.0 from 5.8.0

2017-12-23 Thread Randall S. Becker
On December 23, 2017 12:44 PM, Ævar Arnfjörð Bjarmason wrote: > > In late 2010 I bumped our perl version dependency from 5.6.* to 5.8.0[1]. Git > had been failing for a while on <5.8, and it was suspected that nobody cared > enough to keep using it, which turned out to be true. > > Follow that u