Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-27 Thread Ævar Arnfjörð Bjarmason
On Thu, Sep 27 2018, Derrick Stolee wrote: > On 9/27/2018 11:21 AM, Ben Peart wrote: >> >> >> On 9/26/2018 2:54 PM, Derrick Stolee wrote: >>> >>> GIT_TEST_INDEX_THREADS=1 >>> >> >> Because the test repos are so small (ie smaller than 10K files), the >> test suite already executes as if

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-27 Thread Derrick Stolee
On 9/27/2018 11:21 AM, Ben Peart wrote: On 9/26/2018 2:54 PM, Derrick Stolee wrote: GIT_TEST_INDEX_THREADS=1 Because the test repos are so small (ie smaller than 10K files), the test suite already executes as if GIT_TEST_INDEX_THREADS=1 is set (ie single threaded).  I added the test

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-27 Thread Ben Peart
On 9/26/2018 2:54 PM, Derrick Stolee wrote: On 9/26/2018 2:43 PM, Thomas Gummerer wrote: On 09/26, Derrick Stolee wrote: This is a bit tricky to do, but I will investigate. For some things, the values can conflict with each other (GIT_TEST_SPLIT_INDEX doesn't play nicely with other index

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-27 Thread Derrick Stolee
On 9/27/2018 11:14 AM, Ben Peart wrote: On 9/26/2018 2:44 PM, Derrick Stolee wrote: On 9/26/2018 1:59 PM, Junio C Hamano wrote: Derrick Stolee writes: Perhaps removing the middle columns of data and just " ) " would be easier? We could also remove tabs to save space. For example:

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-27 Thread Ben Peart
On 9/26/2018 2:44 PM, Derrick Stolee wrote: On 9/26/2018 1:59 PM, Junio C Hamano wrote: Derrick Stolee writes: In an effort to ensure new code is reasonably covered by the test suite, we now have contrib/coverage-diff.sh to combine the gcov output from 'make coverage-test ; make

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-26 Thread Elijah Newren
On Tue, Sep 25, 2018 at 11:44 AM Derrick Stolee wrote: > c3b9bc94b9b (Elijah Newren 2018-09-05 10:03:07 -0700 > 181)options.filter = xstrdup(value); I blame Duy; he was the one who wanted me to look for and remove stray semicolons in additional places[1]. ;-) All joking aside,

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-26 Thread Derrick Stolee
On 9/26/2018 2:43 PM, Thomas Gummerer wrote: On 09/26, Derrick Stolee wrote: This is a bit tricky to do, but I will investigate. For some things, the values can conflict with each other (GIT_TEST_SPLIT_INDEX doesn't play nicely with other index options, I think). Just commenting on this point.

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-26 Thread Derrick Stolee
On 9/26/2018 1:59 PM, Junio C Hamano wrote: Derrick Stolee writes: In an effort to ensure new code is reasonably covered by the test suite, we now have contrib/coverage-diff.sh to combine the gcov output from 'make coverage-test ; make coverage-report' with the output from 'git diff A B' to

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-26 Thread Thomas Gummerer
On 09/26, Derrick Stolee wrote: > This is a bit tricky to do, but I will investigate. For some things, the > values can conflict with each other (GIT_TEST_SPLIT_INDEX doesn't play > nicely with other index options, I think). Just commenting on this point. I think all the index options should be

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-26 Thread Junio C Hamano
Derrick Stolee writes: > In an effort to ensure new code is reasonably covered by the test > suite, we now have contrib/coverage-diff.sh to combine the gcov output > from 'make coverage-test ; make coverage-report' with the output from > 'git diff A B' to discover _new_ lines of code that are

RE: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-26 Thread Jason Pyeron
> -Original Message- > From: Derrick Stolee > Sent: Wednesday, September 26, 2018 6:43 AM > > On 9/25/2018 5:12 PM, Ben Peart wrote: > > > > > > On 9/25/2018 2:42 PM, Derrick Stolee wrote: > >> In an effort to ensure new code is reasonably covered by the test > >> suite, we now have

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-26 Thread Derrick Stolee
On 9/26/2018 6:56 AM, Jason Pyeron wrote: -Original Message- From: Derrick Stolee Sent: Wednesday, September 26, 2018 6:43 AM On 9/25/2018 5:12 PM, Ben Peart wrote: On 9/25/2018 2:42 PM, Derrick Stolee wrote: In an effort to ensure new code is reasonably covered by the test suite, we

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-26 Thread Derrick Stolee
On 9/25/2018 5:12 PM, Ben Peart wrote: On 9/25/2018 2:42 PM, Derrick Stolee wrote: In an effort to ensure new code is reasonably covered by the test suite, we now have contrib/coverage-diff.sh to combine the gcov output from 'make coverage-test ; make coverage-report' with the output from

Re: Git Test Coverage Report (Tuesday, Sept 25)

2018-09-25 Thread Ben Peart
On 9/25/2018 2:42 PM, Derrick Stolee wrote: In an effort to ensure new code is reasonably covered by the test suite, we now have contrib/coverage-diff.sh to combine the gcov output from 'make coverage-test ; make coverage-report' with the output from 'git diff A B' to discover _new_ lines