Hi Elijah,
On Mon, Sep 30, 2019 at 12:11:06PM -0700, Elijah Newren wrote:
> Commits 404ebceda01c ("dir: also check directories for matching
> pathspecs", 2019-09-17) and 89a1f4aaf765 ("dir: if our pathspec might
> match files under a dir, recurse into it", 2019-09-17) added calls to
> match_pathsp
eally know perl (though printf syntax is almost universal).
Cheers
Kunal Tyagi
On Mon, 30 Sep 2019, Junio C Hamano wrote:
> "Kunal Tyagi via GitGitGadget" writes:
>
> > From: Kunal Tyagi
> > Subject: Re: [PATCH v2 1/1] git-add--interactive.perl: Add progress counter
>
gt; previous value of promisors) is also free()'d. This double-free error
> was unrecoverable for the user without removing the filter or re-cloning
> the repo and hoping to miss this edge case.
>
> Now, when promisor_remote_move_to_tail() would be a no-op, just do a
> no-op. In
On Mon, Sep 30, 2019 at 3:48 AM Junio C Hamano wrote:
>
> Alex Henrie writes:
>
> > Well, I admit that code clarity is somewhat subjective. To me it's not
> > obvious that "if (q->nr <= j)" means "if the loop exited normally",
>
> I actually do not have too much problem with this side of the
> eq
On Mon, Sep 30, 2019 at 05:14:37PM -0400, Jeff King wrote:
> > This chosen label was perfectly reasonable when recursiveness kicks in,
> > i.e. when there are multiple merge bases. (I can't think of a better
> > label in such cases.) But it is actually somewhat misleading when there
> > is a uni
On Sat, Aug 17, 2019 at 11:41:24AM -0700, Elijah Newren wrote:
> In commit 7ca56aa07619 ("merge-recursive: add a label for ancestor",
> 2010-03-20), a label was added for the '||' line to make it have
> the more informative heading '|| merged common ancestors', with
> the statement:
>
>
On 9/27/19 8:40 PM, Junio C Hamano wrote:
> SZEDER Gábor writes:
>
>>> +#define MIDX_PROGRESS (1 << 0)
>>
>> Please consider using an enum.
>
> If they are used by assiging one of their values, definitely a good
> idea to use an enum. Are debuggers clever enough that they can
> tell, when t
Eric Wong writes:
> While we cannot rely on a `__typeof__' operator being portable
> to use with `offsetof'; we can calculate the pointer offset
> using an existing pointer and the address of a member using
> pointer arithmetic.
> +/*
> + * like offsetof(), but takes a pointer to type instead of
On 9/27/19 8:49 PM, Junio C Hamano wrote:
diff --git a/midx.c b/midx.c
index b2673f52e8..54e4e93b2b 100644
--- a/midx.c
+++ b/midx.c
@@ -449,6 +449,8 @@ struct pack_list {
uint32_t nr;
uint32_t alloc;
struct multi_pack_index *m;
+ struct progre
On Fri, Sep 27, 2019 at 08:24:37AM -0700, d...@linuxprogrammer.org wrote:
- generate a signify-compatible cryptographic signature of the
verbatim
patch content, perhaps slightly normalized for things like LF vs. CRLF
line endings (see minisign/libsodium for crypto details)
- include both the sig
> > + set tags d_--
>
> I'm afraid I don't follow what this hunk is supposed to do.
>
> You set the variable ::conflict_state to the values like OURS, THEIRS,
> CONTEXT, but I don't see th
Hi Junio,
On Sat, 28 Sep 2019, Junio C Hamano wrote:
> "Johannes Schindelin via GitGitGadget"
> writes:
>
> > ---
> > Makefile | 2 +-
> > compat/mingw.c| 5 -
> > git-compat-util.h | 4 +++-
> > compat/qsort.c => qsort.c | 2 +-
> > 4 files changed, 5 i
Derrick Stolee wrote:
> On 9/23/2019 9:03 PM, Eric Wong wrote:
> > This macro is popular within the Linux kernel for supporting
> > intrusive data structures such as linked lists, red-black trees,
> > and chained hash tables while allowing the compiler to do
> > type checking.
> >
> > I intend to
Hi,
On Fri, 27 Sep 2019, Pratyush Yadav wrote:
> On 26/09/19 10:46AM, Thomas Klaeger via GitGitGadget wrote:
> > From: Thomas Klaeger
> >
> > Git for Windows 2.x ships with an executable that starts the Git Bash
> > with all the environment variables and what not properly set up. It is
> > also
Johannes Schindelin wrote:
> Hi Eric,
>
> On Tue, 24 Sep 2019, Eric Wong wrote:
>
> > Patches 1-11 are largely unchanged from the original series with the
> > exception of 2, which is new and posted at:
> >
> > https://public-inbox.org/git/20190908074953.kux7zz4y7iolqko4@whir/
> >
> > 12-17
Derrick Stolee wrote:
> On 9/23/2019 9:03 PM, Eric Wong wrote:
> > This is less error-prone than "const void *" as the compiler
> > now detects invalid types being passed.
> [snip]
> > diff --git a/hashmap.h b/hashmap.h
> > index 40bcc64289..2a4b4a3954 100644
> > --- a/hashmap.h
> > +++ b/hashmap.
Hi Junio,
On Sun, 29 Sep 2019, Junio C Hamano wrote:
> "Johannes Schindelin via GitGitGadget"
> writes:
>
> > diff --git a/t/test-lib.sh b/t/test-lib.sh
> > index d1ba33745a..f21c781e68 100644
> > --- a/t/test-lib.sh
> > +++ b/t/test-lib.sh
> > @@ -695,7 +695,7 @@ test_failure_ () {
> > say_
Hi Denton,
On Thu, 26 Sep 2019, Denton Liu wrote:
> On Thu, Sep 26, 2019 at 11:01:32PM +0200, Johannes Schindelin wrote:
> >
> > On Thu, 26 Sep 2019, Denton Liu wrote:
> >
> > > Hi Dscho,
> > >
> > > On Thu, Sep 26, 2019 at 01:30:10AM -0700, Johannes Schindelin via
> > > GitGitGadget wrote:
> >
Alex Henrie writes:
> Well, I admit that code clarity is somewhat subjective. To me it's not
> obvious that "if (q->nr <= j)" means "if the loop exited normally",
I actually do not have too much problem with this side of the
equation. I however do see problem with squashing the two diff_q
calls
Hi,
On Fri, 27 Sep 2019, Pratyush Yadav wrote:
> On 27/09/19 08:10AM, Bert Wesarg wrote:
> > On Fri, Sep 27, 2019 at 12:40 AM Pratyush Yadav
> > wrote:
> > >
> > > On 26/09/19 02:17PM, Johannes Schindelin via GitGitGadget wrote:
> > > > From: Johannes Schindelin
> > > >
> > > > Since v2.9.0, G
od at driving stuff to cache.
> > > Likewise, having a framework in C would make it a lot easier to improve
> > > debugging, e.g. by making test scripts "resumable" (guarded by an
> > > option, it could store a complete state, including a copy of the trash
> > &g
On 09/28, Junio C Hamano wrote:
> Thomas Gummerer writes:
>
> >> I thought it was to be 1700 UTC, which currently is 1800 BST her in UK, and
> >> 1900 CST in Europe.
> >
> > That's my recollection as well, and what the calendar should say.
> > Thanks for flagging this!
> >
> > I don't know. I'd
On Sun, Sep 29, 2019 at 7:36 PM Junio C Hamano wrote:
>
> Alex Henrie writes:
>
> > The condition "if (q->nr <= j)" checks whether the loop exited normally
> > or via a break statement. This check can be avoided by replacing the
> > jump out of the inner loop with a jump to the end of the outer l
On Sun, Sep 29, 2019 at 7:22 PM Junio C Hamano wrote:
>
> Alex Henrie writes:
>
> > The variable g was being set to the same value both at the beginning of
> > the function and before the loop. The assignment before the loop was
> > kept because it helps clarify what the loop does, and the redund
On 28.09.2019 6:47, Junio C Hamano wrote:
s/bugged/buggy/ perhaps? Usually people do not place hidden
listening devices in tests ;-)
Yes, hinting those hidden listening devices was an oversight. Thanks for
your help in putting them back undercover!
I understand that you already changed the
initialization of packed_git when setting
git-grep up. There'll be a small overhead in the cases where we didn't
really needed to prepare packed_git during execution but this shouldn't
be very noticeable.
Also, packed_git may be re-initialized by
packfile.c:reprepare_packed_git().
peedup, so let's re-enable threads in non-worktree grep.
Grepping 'abcd[02]' ("Regex 1") and '(static|extern) (int|double) \*'
("Regex 2") at chromium's repository[1] I got:
Threads | Regex 1 | Regex 2
-||---
1
Alex Henrie writes:
> The condition "if (q->nr <= j)" checks whether the loop exited normally
> or via a break statement. This check can be avoided by replacing the
> jump out of the inner loop with a jump to the end of the outer loop.
>
> With the break replaced by a goto, the two diff_q calls t
"Kunal Tyagi via GitGitGadget" writes:
> From: Kunal Tyagi
> Subject: Re: [PATCH v2 1/1] git-add--interactive.perl: Add progress counter
> in the prompt
Either of these two, perhaps (I'd use the former if I were writing
this patch):
add -i: show progre
Alex Henrie writes:
> The variable g was being set to the same value both at the beginning of
> the function and before the loop. The assignment before the loop was
> kept because it helps clarify what the loop does, and the redundant
> assignment at the beginning of the function was removed.
Wr
CB Bailey writes:
> For easier discussion, I've snipped the original patch and replaced with
> one with enough context to show the entire function.
>
> I was reviewing this patch and it appeared to introduce a change in
> behaviour.
>
>> diff --git a/diffcore-break.c b/diffcore-break.c
>> index 8
On Sun, Sep 29, 2019 at 3:37 AM CB Bailey wrote:
>
> Previously, if the condition matched in the inner loop, the function
> would null out the entry in the queue that that inner loop had reached
> (q->queue[j] = NULL) and then break out of the inner loop. This meant
> that the outer loop would ski
Hi guys, any updates?
On 22.09.19 02:36, Alicenab wrote:
Hi there!
I have a translated ProGit2 book to Azerbaijan language.
As code of country name name for our country(az) have already taken, I
have created "aze" version of it.
I hope it will be no problem for you.
Partial translations availa
Since this is a git-gui dialog/prompt, why not use the git-gui icon?
This will mean some uniformity between all the platforms (though I'm not
sure if other platforms even use GIT_ASK_YESNO). It would also probably
save you the hacks needed to find out the git-for-windows icon.
Well, there is th
One minor nitpick: please add a comment at the top of the file
documenting the `--title` option, and the usage of the program in
general.
Other than that, looks good. Thanks.
On 26/09/19 08:29AM, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin
>
> "Question?" is maybe
What is the difference between SSH_ASKPASS and GIT_ASKPASS? On my first
read, I assumed SSH_ASKPASS is replaced by GIT_ASKPASS, but I might be
wrong.
On 26/09/19 08:29AM, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin
>
> Signed-off-by: Johannes Schindelin
> ---
> gi
On 26/09/19 08:29AM, Heiko Voigt via GitGitGadget wrote:
> From: Heiko Voigt
>
> Make use of the new environment variable GIT_ASK_YESNO to support the
> recently implemented fallback in case unlink, rename or rmdir fail for
> files in use on Windows. The added dialog will present a yes/no questio
Hi Philip, Bert,
Is there any way I can test this change? Philip, I ran the rebase you
mention in the GitHub issue [0], and I get that '9c8cba6862abe5ac821' is
an unknown revision.
Is there any quick way I can reproduce this (maybe on a sample repo)?
[0] https://github.com/git-for-windows/git/
On Sat, Sep 28, 2019 at 06:56:46PM -0600, Alex Henrie wrote:
> The condition "if (q->nr <= j)" checks whether the loop exited normally
> or via a break statement. This check can be avoided by replacing the
> jump to the end of the loop with a jump to the end of the function.
>
> With the break rep
Eric Wong writes:
> Patches 1-11 are largely unchanged from the original series with the
> exception of 2, which is new and posted at:
>
> https://public-inbox.org/git/20190908074953.kux7zz4y7iolqko4@whir/
>
> 12-17 take further steps to get us away from hashmap_entry being
> the first elem
On Thu, Sep 26, 2019 at 8:50 PM Jeff King wrote:
>
> On Thu, Sep 26, 2019 at 10:14:17PM +0200, Johannes Schindelin wrote:
>
> > However, I think that this patch should at least be accompanied by a
> > commit message that suggests that some thought was put into it, and that
> > concerns like mine w
On 2019-09-28 at 23:31:33, Junio C Hamano wrote:
> "brian m. carlson" writes:
>
> > On 2019-09-07 at 17:26:53, Junio C Hamano wrote:
> >> * bc/object-id-part17 (2019-08-19) 26 commits
> >> ...
> >> - builtin/replace: make hash size independent
> >>
> >> Preparation for SHA-256 upgrade continue
"brian m. carlson" writes:
> On 2019-09-07 at 17:26:53, Junio C Hamano wrote:
>> * bc/object-id-part17 (2019-08-19) 26 commits
>> ...
>> - builtin/replace: make hash size independent
>>
>> Preparation for SHA-256 upgrade continues.
>>
>> Looked mostly OK, with a possible update.
>> cf. <201
"Johannes Schindelin via GitGitGadget"
writes:
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index d1ba33745a..f21c781e68 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -695,7 +695,7 @@ test_failure_ () {
> say_color error "not ok $test_count - $1"
> shift
> printf '%s
"Johannes Schindelin via GitGitGadget"
writes:
> ---
> Makefile | 2 +-
> compat/mingw.c| 5 -
> git-compat-util.h | 4 +++-
> compat/qsort.c => qsort.c | 2 +-
> 4 files changed, 5 insertions(+), 8 deletions(-)
> rename compat/qsort.c => qsort.c (97%)
Thomas Gummerer writes:
>> I thought it was to be 1700 UTC, which currently is 1800 BST her in UK, and
>> 1900 CST in Europe.
>
> That's my recollection as well, and what the calendar should say.
> Thanks for flagging this!
>
> I don't know. I'd be happy to keep it at 17:00 UTC, but that might b
Johannes Schindelin writes:
> The only problem is that my patch made it into `next` already, according
> to https://github.com/gitgitgadget/git/pull/129 (look for the labels on
> the right side, or for the comments on the bottom), and
> https://github.com/gitster/git/commit/a3f332f4fb10 agrees (l
"Alexandr Miloslavskiy via GitGitGadget"
writes:
> From: Alexandr Miloslavskiy
>
> After I discovered that UTF-16-LE-BOM test was bugged, I decided that
s/bugged/buggy/ perhaps? Usually people do not place hidden
listening devices in tests ;-)
> better tests are required. Possibly the best op
On Sat, Sep 28, 2019 at 12:24 AM Junio C Hamano wrote:
>
> Matheus Tavares Bernardino writes:
>
> > Right, this would be the best way of doing it. However, I think this
> > is not how it's currently implemented. I if correctly understood the
> > code in this call chain:
> >
> > grep_source_load_d
SZEDER Gábor writes:
>> Hmm...
>>
>> > +# ,---ooo-.
>> > +# / D,R e \
>> > +# o--o-o-o---ox
>> > +# \B/
>> > +# `---ooo-'
>> > +#Ac
>>
>> What's the first parent of the merge between
Eric Wong writes:
> C is fine for unit tests, and maybe we can use more unit tests
> and less integration tests.
Nicely put. I often find it somewhat disturbing that what some of
the t/helper/ tests are trying to exercise is at too low a level
that the distance from the real-world observable ef
e-one-file.
>>
>> Oh, sorry, I did not mean to say that we should do away with this at
>> all! Rather, I meant to say that `merge-index` could detect when it was
>> asked to run `git-merge-one-file` and re-route to internal code instead
>> of spawning a process. If an
William Baker writes:
> On 9/20/19 1:10 PM, Junio C Hamano wrote:
>>> diff --git a/midx.c b/midx.c
>>> index b2673f52e8..54e4e93b2b 100644
>>> --- a/midx.c
>>> +++ b/midx.c
>>> @@ -449,6 +449,8 @@ struct pack_list {
>>> uint32_t nr;
>>> uint32_t alloc;
>>> struct multi_pack_index *m;
SZEDER Gábor writes:
> On Fri, Sep 20, 2019 at 09:53:48AM -0700, William Baker via GitGitGadget
> wrote:
>> diff --git a/midx.h b/midx.h
>> index f0ae656b5d..e6fa356b5c 100644
>> --- a/midx.h
>> +++ b/midx.h
>> @@ -37,6 +37,8 @@ struct multi_pack_index {
>> char object_dir[FLEX_ARRAY];
>>
Matheus Tavares Bernardino writes:
> Right, this would be the best way of doing it. However, I think this
> is not how it's currently implemented. I if correctly understood the
> code in this call chain:
>
> grep_source_load_driver() > userdiff_find_by_path() >
> git_check_attr() > collect_some_
On 2019-09-27 at 12:55:27, Ian Kemp wrote:
> Hi,
>
> Currently, git stash's exit code is 0 regardless of whether it
> performed a stash operation or not. Third parties invoking git stash
> are therefore unable to determine whether a stash was actually made or
> not.
>
> It would be helpful if the
On Thu, Sep 26, 2019 at 11:44:48PM +0200, SZEDER Gábor wrote:
> All that was over a year and a half ago, and these limitations weren't
> a maintenance burden at all so far, and nobody needed that escape
> hatch.
>
> Well, nobody except me, that is :) When I saw back then that t1510
> saves the s
On Wed, Sep 25, 2019 at 05:33:00PM -0700, Jonathan Tan wrote:
> Does anyone have ideas or plans for this? I know that (at least) "grep"
> and "index-pack" have their own implementations, and it would be great
> to just have one that all code can use.
> [..]
> Searching reveals [2], but I don't thi
On 26/09/2019 08:20, Jeff King wrote:
> On Tue, Sep 24, 2019 at 04:52:56PM -0700, Emily Shaffer wrote:
>> I helped my other FOSS project to adopt a Code of Conduct earlier in
>> the year (https://github.com/openbmc/docs/blob/master/code-of-conduct.md)
>> and we got around this by asking for volunte
I was going to make a bug-report about this funny behavior, but
decided to search the list first.
Yeah, I smiled at
Expanding reachable commits in commit graph: 139276% (870481/625), done.
when I did the "git gc --prune=now" on the kernel, and apparently
actually looked at the noise for the
On Fri, Sep 27, 2019 at 04:17:46AM +0200, SZEDER Gábor wrote:
> On Fri, Sep 27, 2019 at 03:09:30AM +0200, SZEDER Gábor wrote:
> > On Wed, Sep 25, 2019 at 01:39:19PM -0700, Denton Liu wrote:
> > > Hi Elijah,
> > >
> > > I ran into a segfault on MacOS. I managed to bisect it down to
> > > 404ebceda0
On Fri, Sep 27, 2019 at 8:55 AM Ian Kemp wrote:
> Currently, git stash's exit code is 0 regardless of whether it
> performed a stash operation or not. Third parties invoking git stash
> are therefore unable to determine whether a stash was actually made or
> not.
>
> It would be helpful if there w
On 10.09.2019 08:13, Konstantin Ryabitsev wrote:
# Proposed approach
I recommend that we provide a way to include cryptographic signature
information natively using git-format-patch, using roughly the following
process:
- generate a signify-compatible cryptographic signature of the verbatim
pa
Hi Alban
On 25/09/2019 21:13, Alban Gruin wrote:
This can be seen as a continuation of ag/reduce-rewriting-todo.
Currently, complete_action() releases its todo list before calling
sequencer_continue(), which reloads the todo list from the disk. This
series removes this useless round trip.
Pat
Hi Alban
On 25/09/2019 21:13, Alban Gruin wrote:
get_replay_opts() did not fill `squash_onto' if possible, meaning that
I'm not sure what you mean by 'if possible' here, I think the sentance
makes sense without that.
this field should be read from the disk by the sequencer through
read_pop
Hi Alban
Thanks for removing some more unnecessary work reloading the the todo list.
On 25/09/2019 21:13, Alban Gruin wrote:
Currently, complete_action() calls sequencer_continue() to do the
rebase. Even though the former already has the todo list, the latter
loads it from the disk and parses
On 27/09/19 08:10AM, Bert Wesarg wrote:
> On Fri, Sep 27, 2019 at 12:40 AM Pratyush Yadav
> wrote:
> >
> > Hi,
> >
> > On 26/09/19 02:17PM, Johannes Schindelin via GitGitGadget wrote:
> > > From: Johannes Schindelin
> > >
> > > Since v2.9.0, Git knows about the config variable core.hookspath
> >
l e.g. when cherry-picking on
> top of a branch that already has your v1.
I agree that we need more in the commit messages here. It is
helpful to include _why_ you are doing this. Keep in mind
that your cover letter is not recorded with the commit at all.
Further, when updating a patch series
Hi,
On Thu, 26 Sep 2019, Alex Henrie wrote:
> Signed-off-by: Alex Henrie
Hrm, the commit message should reflect Stolee's careful consideration,
no? An empty commit message won't be helpful e.g. when cherry-picking on
top of a branch that already has your v1.
Ciao,
Johannes
> ---
> commit-gr
On Fri, Sep 27, 2019 at 11:51:07AM +0200, Anders Janmyr wrote:
> Hi,
>
> I'm not sure if this is a bug or not but `git describe` gives
> different results when the repo has been cloned with `--depth` or not.
>
> In the example below from the git repository the number of additional
> commits since
On 9/26/2019 10:45 PM, Jeff King wrote:
> On Tue, Sep 24, 2019 at 08:01:58PM -0600, Alex Henrie wrote:
>
>> diff --git a/wrapper.c b/wrapper.c
>> index c55d7722d7..c23ac6adcd 100644
>> --- a/wrapper.c
>> +++ b/wrapper.c
>> @@ -469,13 +469,12 @@ int git_mkstemps_mode(char *pattern, int suffix_len,
Hi Rohit
This is an improvement but there are a couple of outstanding issues from
the previous round with regard to handing --ignore-date when
GIT_COMMITTER_DATE is set. I'll try and look at the rest of the series soon.
On 07/09/2019 12:50, Rohit Ashiwal wrote:
rebase am already has this fla
On 09/27, Beyondhorizon Zheng wrote:
> [git issue] git am failed for patches of converting the file format of
> source codes from dos to unix
>
> Git version: git version 2.23.0
> Host PC: ubuntu 16.04.10
> Reporter: Shuang Zheng
>
> I have submitted a patch which convert the file format of sourc
On Fri, Sep 27, 2019 at 12:40 AM Pratyush Yadav wrote:
>
> Hi,
>
> On 26/09/19 02:17PM, Johannes Schindelin via GitGitGadget wrote:
> > From: Johannes Schindelin
> >
> > Since v2.9.0, Git knows about the config variable core.hookspath
> > that allows overriding the path to the directory containin
Looks good. Thanks.
On 25/09/19 10:38PM, Bert Wesarg wrote:
> Replace the hand-coded call to git check-attr with the already provided one.
>
> Signed-off-by: Bert Wesarg
> ---
> lib/diff.tcl | 15 +--
> 1 file changed, 1 insertion(+), 14 deletions(-)
>
> diff --git a/lib/diff.tcl b
On Thu, Sep 26, 2019 at 03:12:15PM +0200, Christian Couder wrote:
> On https://www.outreachy.org/apply/project-selection/#git it looks
> like we will only have 1 intern as the title of our section is "Git -
> 1 intern". I wonder if it's because only funding for 1 intern has been
> secured or if th
On Thu, Sep 26, 2019 at 10:14:17PM +0200, Johannes Schindelin wrote:
> I mean, if there is _any_ performance-critical code path hitting this
> unrolled loop, we may want to keep it unrolled.
The loop in question is maybe a few dozen instructions, and then it
immediately makes an open() syscall, w
On Tue, Sep 24, 2019 at 08:01:58PM -0600, Alex Henrie wrote:
> diff --git a/wrapper.c b/wrapper.c
> index c55d7722d7..c23ac6adcd 100644
> --- a/wrapper.c
> +++ b/wrapper.c
> @@ -469,13 +469,12 @@ int git_mkstemps_mode(char *pattern, int suffix_len,
> int mode)
> filename_template = &pattern
On Fri, Sep 27, 2019 at 03:09:30AM +0200, SZEDER Gábor wrote:
> On Wed, Sep 25, 2019 at 01:39:19PM -0700, Denton Liu wrote:
> > Hi Elijah,
> >
> > I ran into a segfault on MacOS. I managed to bisect it down to
> > 404ebceda0 (dir: also check directories for matching pathspecs,
> > 2019-09-17), whi
On Wed, Sep 25, 2019 at 01:39:19PM -0700, Denton Liu wrote:
> Hi Elijah,
>
> I ran into a segfault on MacOS. I managed to bisect it down to
> 404ebceda0 (dir: also check directories for matching pathspecs,
> 2019-09-17), which should be the patch in the parent thread. The test
> case below works f
e discussed options, this one is pretty easy to
understand.
> --- a/t/t0410-partial-clone.sh
> +++ b/t/t0410-partial-clone.sh
> @@ -429,6 +429,18 @@ test_expect_success 'rev-list dies for missing objects
> on cmd line' '
> done
> '
>
> +test
Hi Denton,
On Thu, Sep 26, 2019 at 1:35 PM Denton Liu wrote:
>
> On Wed, Sep 25, 2019 at 02:55:30PM -0700, Denton Liu wrote:
> > Looks correct to me. I don't see why this wouldn't reproduce. I'll send
> > you more information if I figure anything else out.
>
> I looked into it a little more and I
Hi Dscho,
On Thu, Sep 26, 2019 at 11:01:32PM +0200, Johannes Schindelin wrote:
> Hi Denton,
>
> On Thu, 26 Sep 2019, Denton Liu wrote:
>
> > Hi Dscho,
> >
> > On Thu, Sep 26, 2019 at 01:30:10AM -0700, Johannes Schindelin via
> > GitGitGadget wrote:
> > > From: Johannes Schindelin
> > >
> > > M
On 26/09/19 08:44PM, Johannes Schindelin wrote:
> Hi,
>
> On Tue, 24 Sep 2019, Pratyush Yadav wrote:
>
> > On 23/09/19 09:35PM, Johannes Schindelin wrote:
> > > Hi,
> > >
> > > On Wed, 18 Sep 2019, Junio C Hamano wrote:
> > >
> > > > We have a new maintainer for git-gui now. Thanks Pratyush for
Hi,
On 26/09/19 02:17PM, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin
>
> Since v2.9.0, Git knows about the config variable core.hookspath
> that allows overriding the path to the directory containing the
> Git hooks.
>
> Since v2.10.0, the `--git-path` option respect
On 26/09/19 10:46AM, Thomas Klaeger via GitGitGadget wrote:
> From: Thomas Klaeger
>
> Git for Windows 2.x ships with an executable that starts the Git Bash
> with all the environment variables and what not properly set up. It is
> also adjusted according to the Terminal emulator option chosen wh
On Thu, Sep 26, 2019 at 09:32:35PM +0200, Johannes Schindelin wrote:
> Hi,
>
> On Thu, 26 Sep 2019, SZEDER Gábor wrote:
>
> > On Mon, Sep 23, 2019 at 08:07:09PM +0200, SZEDER Gábor wrote:
> > > Here is one more idea for microprojects:
> > >
> > > Find a group of related preprocessor constants a
cleaned up first... so I'm afraid it will be with
us for a while.
> -- snipsnap --
> if test -n "$trace" && test -n "$test_untraceable"
> then
> # '-x' tracing requested, but this test script can't be reliably
> # traced, unless it is r
On 26/09/2019 20:05, Pedro Sousa wrote:
Using the pull command instead of push is more accurate when giving
instructions on placing the psuh command in alphabetical order.
Signed-off-by: Pedro Sousa
---
Changes since v1: Addressed Philip's comments on making alphabetical
sort instructions more
On Thu, Sep 26, 2019 at 03:20:46AM -0400, Jeff King wrote:
> So here's a patch that I think improves the situation.
Looks great to me and addresses my only concern with the original patch.
Hearty ACK.
- Emily
On Thu, Sep 26, 2019 at 9:30 PM Pratyush Yadav wrote:
> Why are you changing the Alt+4 binding?
I couldn't really find an easier way before.
> This means your feature won't
> work for people who use the mouse to move around in the UI (which I
> suppose would be a majority).
True. I would much p
On 2019-09-26 3:15 p.m., Pratyush Yadav wrote:
On 26/09/19 08:54PM, Johannes Sixt wrote:
Am 26.09.19 um 19:31 schrieb Birger Skogeng Pedersen:
Every once in a while, I get the "This repository currently has
approximately (some number) loose objects." popup dialog.
I don't want to sound arrogan
Am 26.09.19 um 21:15 schrieb Pratyush Yadav:
> Reading the Stackoverflow link, it seems this is already possible via an
> undocumented config variable "gui.gcwarning". I haven't tried using it
> though, but I see no reason for it to not work (looking at
> git-gui.sh:4141).
Ah! That explains why
On Thu, Sep 26, 2019 at 9:15 PM Pratyush Yadav wrote:
> Talking about auto compression, would it be a better idea to let users
> disable the dialog, and then if they do want auto compression, they can
> just run a cron job (or the Windows equivalent) to do this on their
> repos?
Personally I woul
On Thu, Sep 26, 2019 at 04:20:05PM +0200, Alejandro Sanchez wrote:
> Are there any updates to this problem?
The fix for the original bug went into Git v2.22.1.
-Peff
Hi,
On Fri, 27 Sep 2019, Pratyush Yadav wrote:
> On 26/09/19 08:25PM, Bert Wesarg wrote:
> > On Thu, Sep 26, 2019 at 7:43 PM Johannes Schindelin via GitGitGadget
> > wrote:
> > >
> > > From: Johannes Schindelin
> > >
> > > When a 1-line file is augmented by a second line, and the user tries to
Hi Denton,
On Thu, 26 Sep 2019, Denton Liu wrote:
> Hi Dscho,
>
> On Thu, Sep 26, 2019 at 01:30:10AM -0700, Johannes Schindelin via
> GitGitGadget wrote:
> > From: Johannes Schindelin
> >
> > MSVC complains about this with `-Wall`, which can be taken as a sign
> > that this is indeed a real bug
On Wed, Sep 25, 2019 at 02:55:30PM -0700, Denton Liu wrote:
> Looks correct to me. I don't see why this wouldn't reproduce. I'll send
> you more information if I figure anything else out.
I looked into it a little more and I think I know why it's being
triggered.
When we checkout 'todo' from 'mas
On Wed, Sep 25, 2019 at 10:09:02AM -0700, Denton Liu wrote:
> On Wed, Sep 25, 2019 at 03:26:57AM -0700, Denton Liu wrote:
> > I tried my hand at fixing the bug but in the hour I spent going at it, I
> > couldn't fix the logic up. The buggy logic is in graph.c:
> > graph_draw_octopus_merge() in cas
Hi,
On Thu, 26 Sep 2019, Derrick Stolee wrote:
> On 9/24/2019 10:01 PM, Alex Henrie wrote:
> > Signed-off-by: Alex Henrie
> > ---
> > wrapper.c | 11 +--
> > 1 file changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/wrapper.c b/wrapper.c
> > index c55d7722d7..c23ac6adcd 10064
901 - 1000 of 116325 matches
Mail list logo
