Re: Re* [PATCH] gitweb: make remote_heads config setting work.

2012-11-21 Thread Jeff King
On Tue, Nov 20, 2012 at 02:21:40PM -0800, Junio C Hamano wrote: > > Good catch. I think the "return" in the existing code suffers from the > > same problem: it will bail on non-word characters in the $mi part, but > > that part should allow arbitrary characters. > > I am tired of keeping the "exp

Re* [PATCH] gitweb: make remote_heads config setting work.

2012-11-20 Thread Junio C Hamano
Jeff King writes: > On Thu, Nov 08, 2012 at 08:40:11PM -0800, Junio C Hamano wrote: > >> Looking at the code before this part: >> >> if (my ($hi, $mi, $lo) = ($key =~ /^([^.]*)\.(.*)\.([^.]*)$/)) { >> $key = join(".", lc($hi), $mi, lc($lo)); >> } else { >> $ke

Re: [PATCH] gitweb: make remote_heads config setting work.

2012-11-09 Thread Jeff King
On Thu, Nov 08, 2012 at 08:40:11PM -0800, Junio C Hamano wrote: > Looking at the code before this part: > > if (my ($hi, $mi, $lo) = ($key =~ /^([^.]*)\.(.*)\.([^.]*)$/)) { > $key = join(".", lc($hi), $mi, lc($lo)); > } else { > $key = lc($key); > } >

Re: [PATCH] gitweb: make remote_heads config setting work.

2012-11-08 Thread Junio C Hamano
Phil Pennock writes: > @@ -2702,6 +2702,7 @@ sub git_get_project_config { > $key = lc($key); > } > $key =~ s/^gitweb\.//; > + $key =~ s/_//g; > return if ($key =~ m/\W/); > > # type sanity check The idea to strip "_" from "remote_heads" to create "remo

Re: [PATCH] gitweb: make remote_heads config setting work.

2012-11-08 Thread Jeff King
On Mon, Nov 05, 2012 at 06:50:47PM -0500, Phil Pennock wrote: > Git configuration items can not contain underscores in their name; the > 'remote_heads' feature can not be enabled on a per-repository basis with > that name. > > This changes the git-config option to be `gitweb.remoteheads` but does