Re: Re* [PATCH 10/15] commit.c: fix a memory leak

2015-03-24 Thread Stefan Beller
On Tue, Mar 24, 2015 at 2:17 PM, Junio C Hamano wrote: > > Move it to dir.c where match_pathspec() is defined. > > Signed-off-by: Junio C Hamano Reviewed-by: Stefan Beller -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org Mor

Re* [PATCH 10/15] commit.c: fix a memory leak

2015-03-24 Thread Junio C Hamano
Duy Nguyen writes: > On Sat, Mar 21, 2015 at 10:59 AM, Junio C Hamano wrote: >> A further tangent (Duy Cc'ed for this point). We might want to >> rethink the interface to ce_path_match() and report_path_error() >> so that we do not have to do a separate allocation of "has this >> pathspec been

Re: [PATCH 10/15] commit.c: fix a memory leak

2015-03-24 Thread Duy Nguyen
On Sat, Mar 21, 2015 at 10:59 AM, Junio C Hamano wrote: > A further tangent (Duy Cc'ed for this point). We might want to > rethink the interface to ce_path_match() and report_path_error() > so that we do not have to do a separate allocation of "has this > pathspec been used?" array. This was a r

Re: [PATCH 10/15] commit.c: fix a memory leak

2015-03-20 Thread Junio C Hamano
Stefan Beller writes: > Signed-off-by: Stefan Beller > --- > builtin/commit.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/builtin/commit.c b/builtin/commit.c > index 961e467..da79ac4 100644 > --- a/builtin/commit.c > +++ b/builtin/commit.c > @@ -229,7 +229,7 @