Re: [PATCH/RFC 0/2] Automate updating git-completion.bash a bit

2018-01-23 Thread Duy Nguyen
On Mon, Jan 22, 2018 at 07:03:24PM +0100, SZEDER Gábor wrote: > On Wed, Jan 17, 2018 at 10:34 AM, Duy Nguyen wrote: > > Actually I forgot another option. What if we automate updating the > > script at "compile" time instead of calling git at run time? E.g. with > > something

Re: [PATCH/RFC 0/2] Automate updating git-completion.bash a bit

2018-01-22 Thread SZEDER Gábor
On Wed, Jan 17, 2018 at 10:34 AM, Duy Nguyen wrote: > Actually I forgot another option. What if we automate updating the > script at "compile" time instead of calling git at run time? E.g. with > something like below, a contributor could just run > > make update-completion

Re: [PATCH/RFC 0/2] Automate updating git-completion.bash a bit

2018-01-17 Thread Duy Nguyen
Actually I forgot another option. What if we automate updating the script at "compile" time instead of calling git at run time? E.g. with something like below, a contributor could just run make update-completion then add git-completion.bash changes to the same patch that introduces new

Re: [PATCH/RFC 0/2] Automate updating git-completion.bash a bit

2018-01-17 Thread Duy Nguyen
On Wed, Jan 17, 2018 at 7:51 AM, SZEDER Gábor wrote: > On Tue, Jan 16, 2018 at 11:36 AM, Nguyễn Thái Ngọc Duy > wrote: >> I noticed --recurse-submodules was missing from git-grep complete >> list. Then I found a couple more should be on the list as well

Re: [PATCH/RFC 0/2] Automate updating git-completion.bash a bit

2018-01-16 Thread SZEDER Gábor
On Tue, Jan 16, 2018 at 11:36 AM, Nguyễn Thái Ngọc Duy wrote: > I noticed --recurse-submodules was missing from git-grep complete > list. Then I found a couple more should be on the list as well and > many more in future may face the same faith. Perhaps this helps remedy > this