Re: [PATCH] Correctly close config file handle in case of error

2015-08-14 Thread Eric Sunshine
On Fri, Aug 14, 2015 at 4:03 PM, Sven Strickroth s...@cs-ware.de wrote: Without this patch there might be open file handle leaks. Signed-off-by: Sven Strickroth em...@cs-ware.de Signed-off-by: Sup Yut Sum ch3co...@gmail.com --- diff --git a/config.c b/config.c index 9fd275f..8138d5d 100644

Re: [PATCH] Correctly close config file handle in case of error

2015-08-14 Thread Eric Sunshine
On Fri, Aug 14, 2015 at 4:21 PM, Sven Strickroth s...@cs-ware.de wrote: Without this patch there might be open file handle leaks. Signed-off-by: Sven Strickroth em...@cs-ware.de Signed-off-by: Sup Yut Sum ch3co...@gmail.com Better. Thanks. Reviewed-by: Eric Sunshine sunsh...@sunshineco.com

Re: [PATCH] Correctly close config file handle in case of error

2015-08-14 Thread Eric Sunshine
On Fri, Aug 14, 2015 at 3:44 PM, Sven Strickroth s...@cs-ware.de wrote: Without this patch there might be open file handle leaks. Thanks, this looks better. One comment below... Signed-off-by: Sven Strickroth em...@cs-ware.de Signed-off-by: Sup Yut Sum ch3co...@gmail.com --- diff --git

Re: [PATCH] Correctly close config file handle in case of error

2015-08-14 Thread Junio C Hamano
Sven Strickroth s...@cs-ware.de writes: Without this patch there might be open file handle leaks. Signed-off-by: Sven Strickroth em...@cs-ware.de Signed-off-by: Sup Yut Sum ch3co...@gmail.com Who are these two people and how are they related to this change? I am wondering if Sup is the