Re: [PATCH] git.c: fix help.autocorrect after 57ea712 breaks it

Duy Nguyen writes: > On Wed, Jan 27, 2016 at 1:49 PM, Junio C Hamano wrote: >> Junio C Hamano writes: >> >>> I spoke too soon, I am afraid. >>> ... >>> I wonder if this would be better done as a multi-part series that >>> goes like this:

Re: [PATCH] git.c: fix help.autocorrect after 57ea712 breaks it

On Wed, Jan 27, 2016 at 1:49 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> I spoke too soon, I am afraid. >> ... >> I wonder if this would be better done as a multi-part series that >> goes like this: >> ... > > So here is the first of the

Re: [PATCH] git.c: fix help.autocorrect after 57ea712 breaks it

Junio C Hamano writes: > I spoke too soon, I am afraid. > ... > I wonder if this would be better done as a multi-part series that > goes like this: > ... So here is the first of the three-patch series to replace it. -- >8 -- From: Junio C Hamano Date:

Re: [PATCH] git.c: fix help.autocorrect after 57ea712 breaks it

Nguyễn Thái Ngọc Duy venit, vidit, dixit 26.01.2016 14:26: > Commit 57ea712 (git.c: make sure we do not leak GIT_* to alias scripts - > 2015-12-20) does not realize that handle_alias() can be called multiple > times because of the forever loop in run_argv(). The commit breaks alias > chains. > >

Re: [PATCH] git.c: fix help.autocorrect after 57ea712 breaks it

Michael J Gruber writes: > Nguyễn Thái Ngọc Duy venit, vidit, dixit 26.01.2016 14:26: >> Commit 57ea712 (git.c: make sure we do not leak GIT_* to alias scripts - >> 2015-12-20) does not realize that handle_alias() can be called multiple >> times because of the forever

Re: [PATCH] git.c: fix help.autocorrect after 57ea712 breaks it

Nguyễn Thái Ngọc Duy writes: > diff --git a/git.c b/git.c > index da278c3..cd733f7 100644 > --- a/git.c > +++ b/git.c > @@ -25,14 +25,15 @@ static const char *env_names[] = { > GIT_PREFIX_ENVIRONMENT > }; > static char *orig_env[4]; > -static int

Re: [PATCH] git.c: fix help.autocorrect after 57ea712 breaks it

Nguyễn Thái Ngọc Duy writes: > Commit 57ea712 (git.c: make sure we do not leak GIT_* to alias scripts - > 2015-12-20) does not realize that handle_alias() can be called multiple > times because of the forever loop in run_argv(). The commit breaks alias > chains. > > Suppose